Re: [PATCH][next] netfilter: nftables: fix incorrect increment of loop counter

2020-12-16 Thread Pablo Neira Ayuso
On Mon, Dec 14, 2020 at 11:40:15PM +, Colin King wrote: > From: Colin Ian King > > The intention of the err_expr cleanup path is to iterate over the > allocated expr_array objects and free them, starting from i - 1 and > working down to the start of the array. Currently the loop counter > is

Re: [PATCH][next] netfilter: nftables: fix incorrect increment of loop counter

2020-12-15 Thread Pablo Neira Ayuso
On Tue, Dec 15, 2020 at 03:38:30PM +0100, Pablo Neira Ayuso wrote: > Hi, > > On Mon, Dec 14, 2020 at 11:40:15PM +, Colin King wrote: > > From: Colin Ian King > > > > The intention of the err_expr cleanup path is to iterate over the > > allocated expr_array objects and free them, starting

Re: [PATCH][next] netfilter: nftables: fix incorrect increment of loop counter

2020-12-15 Thread Pablo Neira Ayuso
Hi, On Mon, Dec 14, 2020 at 11:40:15PM +, Colin King wrote: > From: Colin Ian King > > The intention of the err_expr cleanup path is to iterate over the > allocated expr_array objects and free them, starting from i - 1 and > working down to the start of the array. Currently the loop counter

[PATCH][next] netfilter: nftables: fix incorrect increment of loop counter

2020-12-14 Thread Colin King
From: Colin Ian King The intention of the err_expr cleanup path is to iterate over the allocated expr_array objects and free them, starting from i - 1 and working down to the start of the array. Currently the loop counter is being incremented instead of decremented and also the index i is being