Re: [PATCH][next] pinctrl: pinctrl-single: add allocation failure checking of saved_vals

2018-06-14 Thread Linus Walleij
On Wed, Jun 6, 2018 at 3:43 PM, Colin King wrote: > From: Colin Ian King > > Currently saved_vals is being allocated and there is no check for > failed allocation (which is more likely than normal when using > GFP_ATOMIC). Fix this by checking for a failed allocation and > propagating this erro

Re: [PATCH][next] pinctrl: pinctrl-single: add allocation failure checking of saved_vals

2018-06-07 Thread Tony Lindgren
* Johan Hovold [180607 07:32]: > On Wed, Jun 06, 2018 at 02:43:38PM +0100, Colin King wrote: > > But for this fix, feel free to add: > > Reviewed-by: Johan Hovold Acked-by: Tony Lindgren

Re: [PATCH][next] pinctrl: pinctrl-single: add allocation failure checking of saved_vals

2018-06-07 Thread Colin Ian King
On 07/06/18 08:35, Johan Hovold wrote: > On Wed, Jun 06, 2018 at 07:02:03PM +0300, Andy Shevchenko wrote: >> On Wed, Jun 6, 2018 at 4:43 PM, Colin King wrote: >>> From: Colin Ian King >>> >>> Currently saved_vals is being allocated and there is no check for >>> failed allocation (which is more li

Re: [PATCH][next] pinctrl: pinctrl-single: add allocation failure checking of saved_vals

2018-06-07 Thread Johan Hovold
On Wed, Jun 06, 2018 at 07:02:03PM +0300, Andy Shevchenko wrote: > On Wed, Jun 6, 2018 at 4:43 PM, Colin King wrote: > > From: Colin Ian King > > > > Currently saved_vals is being allocated and there is no check for > > failed allocation (which is more likely than normal when using > > GFP_ATOMIC

Re: [PATCH][next] pinctrl: pinctrl-single: add allocation failure checking of saved_vals

2018-06-07 Thread Johan Hovold
On Wed, Jun 06, 2018 at 02:43:38PM +0100, Colin King wrote: > From: Colin Ian King > > Currently saved_vals is being allocated and there is no check for > failed allocation (which is more likely than normal when using > GFP_ATOMIC). Fix this by checking for a failed allocation and > propagating

Re: [PATCH][next] pinctrl: pinctrl-single: add allocation failure checking of saved_vals

2018-06-06 Thread Andy Shevchenko
On Wed, Jun 6, 2018 at 4:43 PM, Colin King wrote: > From: Colin Ian King > > Currently saved_vals is being allocated and there is no check for > failed allocation (which is more likely than normal when using > GFP_ATOMIC). Fix this by checking for a failed allocation and > propagating this error

[PATCH][next] pinctrl: pinctrl-single: add allocation failure checking of saved_vals

2018-06-06 Thread Colin King
From: Colin Ian King Currently saved_vals is being allocated and there is no check for failed allocation (which is more likely than normal when using GFP_ATOMIC). Fix this by checking for a failed allocation and propagating this error return down the the caller chain. Detected by CoverityScan,