Re: [PATCH][next] power: supply: bq25980: remove redundant zero check on ret

2020-10-08 Thread Sebastian Reichel
Hi, On Tue, Oct 06, 2020 at 12:23:06PM -0500, Dan Murphy wrote: > Colin > > On 10/6/20 12:06 PM, Colin King wrote: > > From: Colin Ian King > > > > Currently ret is assigned to zero and the following statement checks > > if it is non-zero. This check is redundant and can be removed > > > >

Re: [PATCH][next] power: supply: bq25980: remove redundant zero check on ret

2020-10-06 Thread Dan Carpenter
On Tue, Oct 06, 2020 at 06:06:00PM +0100, Colin King wrote: > From: Colin Ian King > > Currently ret is assigned to zero and the following statement checks > if it is non-zero. This check is redundant and can be removed > > Addresses-Coverity: ("Logically dead code") > Fixes: 5069185fc18e

Re: [PATCH][next] power: supply: bq25980: remove redundant zero check on ret

2020-10-06 Thread Dan Murphy
Colin On 10/6/20 12:06 PM, Colin King wrote: From: Colin Ian King Currently ret is assigned to zero and the following statement checks if it is non-zero. This check is redundant and can be removed Addresses-Coverity: ("Logically dead code") Fixes: 5069185fc18e ("power: supply: bq25980: Add

[PATCH][next] power: supply: bq25980: remove redundant zero check on ret

2020-10-06 Thread Colin King
From: Colin Ian King Currently ret is assigned to zero and the following statement checks if it is non-zero. This check is redundant and can be removed Addresses-Coverity: ("Logically dead code") Fixes: 5069185fc18e ("power: supply: bq25980: Add support for the BQ259xx family") Signed-off-by: