Re: [PATCH][next] scsi: lpfc: remove dead code on second !ndlp check

2020-11-23 Thread Martin K. Petersen
On Wed, 18 Nov 2020 13:37:44 +, Colin King wrote: > Currently there is a null check on the pointer ndlp that exits via > error path issue_ct_rsp_exit followed by another null check on the > same pointer that is almost identical to the previous null check > stanza and yet can never can be

Re: [PATCH][next] scsi: lpfc: remove dead code on second !ndlp check

2020-11-19 Thread Martin K. Petersen
Colin, > Currently there is a null check on the pointer ndlp that exits via > error path issue_ct_rsp_exit followed by another null check on the > same pointer that is almost identical to the previous null check > stanza and yet can never can be reached because the previous check > exited via

Re: [PATCH][next] scsi: lpfc: remove dead code on second !ndlp check

2020-11-19 Thread James Smart
On 11/18/2020 5:37 AM, Colin King wrote: From: Colin Ian King Currently there is a null check on the pointer ndlp that exits via error path issue_ct_rsp_exit followed by another null check on the same pointer that is almost identical to the previous null check stanza and yet can never can be

[PATCH][next] scsi: lpfc: remove dead code on second !ndlp check

2020-11-18 Thread Colin King
From: Colin Ian King Currently there is a null check on the pointer ndlp that exits via error path issue_ct_rsp_exit followed by another null check on the same pointer that is almost identical to the previous null check stanza and yet can never can be reached because the previous check exited