Re: [PATCH][next] spi: loopback-test: make several module parameters static

2017-07-18 Thread Mark Brown
On Tue, Jul 18, 2017 at 02:13:35PM +0100, Colin Ian King wrote: > On 18/07/17 14:09, Mark Brown wrote: > > It would be very helpful if you could ensure your commit author and > > e-mail From: line up so that git doesn't make your patches look like > > non-author signoffs. > ACK, will do. Want me

Re: [PATCH][next] spi: loopback-test: make several module parameters static

2017-07-18 Thread Colin Ian King
On 18/07/17 14:09, Mark Brown wrote: > On Tue, Jul 18, 2017 at 01:42:32PM +0100, Colin King wrote: >> From: Colin Ian King > > It would be very helpful if you could ensure your commit author and > e-mail From: line up so that git doesn't make your patches look like > non-author signoffs. > > The

Re: [PATCH][next] spi: loopback-test: make several module parameters static

2017-07-18 Thread Mark Brown
On Tue, Jul 18, 2017 at 01:42:32PM +0100, Colin King wrote: > From: Colin Ian King It would be very helpful if you could ensure your commit author and e-mail From: line up so that git doesn't make your patches look like non-author signoffs. The [next] isn't needed in the subject line either, it

[PATCH][next] spi: loopback-test: make several module parameters static

2017-07-18 Thread Colin King
From: Colin Ian King Several module parameters are local to the source, so make them static. Cleans up several sparse warnings such as: "symbol 'loop_req' was not declared. Should it be static?" Signed-off-by: Colin Ian King --- drivers/spi/spi-loopback-test.c | 14 +++--- 1 file chan