Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div

2017-06-23 Thread Amelie DELAUNAY
On 06/22/2017 05:41 PM, Colin King wrote: From: Colin Ian King Currently the check for range limits on div is incorrect and will never return -EINVAL. Fix this by replacing && with || Detected by CoverityScan, CID#1446580 ("Structurally dead code") Signed-off-by: Colin Ian King --- driver

Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div

2017-06-23 Thread Mark Brown
On Thu, Jun 22, 2017 at 05:49:10PM +0200, Amelie DELAUNAY wrote: > I'm preparing a v2 for the initial patchset introducing spi-stm32, if you > agree, I can directly add your fix. Please don't resubmit patches that have already been applied, you should submit patches against current code in the tr

Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div

2017-06-22 Thread Colin Ian King
On 22/06/17 16:49, Amelie DELAUNAY wrote: > Hi Colin, > > I'm preparing a v2 for the initial patchset introducing spi-stm32, if > you agree, I can directly add your fix. Yep, please do, sounds like a plan. Colin > > Regards, > Amelie > > On 06/22/2017 05:41 PM, Colin King wrote: >> From: Colin

Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div

2017-06-22 Thread Amelie DELAUNAY
Hi Colin, I'm preparing a v2 for the initial patchset introducing spi-stm32, if you agree, I can directly add your fix. Regards, Amelie On 06/22/2017 05:41 PM, Colin King wrote: From: Colin Ian King Currently the check for range limits on div is incorrect and will never return -EINVAL. Fix

[PATCH][spi-next] spi: stm32: fix range limit checks on div

2017-06-22 Thread Colin King
From: Colin Ian King Currently the check for range limits on div is incorrect and will never return -EINVAL. Fix this by replacing && with || Detected by CoverityScan, CID#1446580 ("Structurally dead code") Signed-off-by: Colin Ian King --- drivers/spi/spi-stm32.c | 2 +- 1 file changed, 1 in