Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-08 Thread Rafael J. Wysocki
On Wednesday, January 08, 2014 03:41:52 PM Yinghai Lu wrote: > On Mon, Jan 6, 2014 at 12:41 PM, Rafael J. Wysocki wrote: > > >> Not sure how that could happen. > >> > >> If it would really happen, we could set dev->match_driver to 0 in > >> pci_stop_dev. > > > > Simply, run "modprobe -r driver

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-08 Thread Yinghai Lu
On Mon, Jan 6, 2014 at 12:41 PM, Rafael J. Wysocki wrote: >> Not sure how that could happen. >> >> If it would really happen, we could set dev->match_driver to 0 in >> pci_stop_dev. > > Simply, run "modprobe -r driver && modprobe driver" in a loop and > remove the PCI host bridge the given

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-08 Thread Yinghai Lu
On Mon, Jan 6, 2014 at 12:41 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: Not sure how that could happen. If it would really happen, we could set dev-match_driver to 0 in pci_stop_dev. Simply, run modprobe -r driver modprobe driver in a loop and remove the PCI host bridge the given

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-08 Thread Rafael J. Wysocki
On Wednesday, January 08, 2014 03:41:52 PM Yinghai Lu wrote: On Mon, Jan 6, 2014 at 12:41 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: Not sure how that could happen. If it would really happen, we could set dev-match_driver to 0 in pci_stop_dev. Simply, run modprobe -r driver

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-06 Thread Rafael J. Wysocki
On Monday, January 06, 2014 11:28:43 AM Yinghai Lu wrote: > On Thu, Jan 2, 2014 at 4:45 PM, Rafael J. Wysocki wrote: > > On Thursday, January 02, 2014 02:47:04 PM Yinghai Lu wrote: > >> > >> No. It should be before removing all root bus devices. > >> as they need to access the pci devices during

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-06 Thread Yinghai Lu
On Thu, Jan 2, 2014 at 4:45 PM, Rafael J. Wysocki wrote: > On Thursday, January 02, 2014 02:47:04 PM Yinghai Lu wrote: >> >> No. It should be before removing all root bus devices. >> as they need to access the pci devices during stop ioapic and dmar. >> >> Also ioapic itself could one one pci

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-06 Thread Yinghai Lu
On Thu, Jan 2, 2014 at 4:45 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Thursday, January 02, 2014 02:47:04 PM Yinghai Lu wrote: No. It should be before removing all root bus devices. as they need to access the pci devices during stop ioapic and dmar. Also ioapic itself could one one

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-06 Thread Rafael J. Wysocki
On Monday, January 06, 2014 11:28:43 AM Yinghai Lu wrote: On Thu, Jan 2, 2014 at 4:45 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Thursday, January 02, 2014 02:47:04 PM Yinghai Lu wrote: No. It should be before removing all root bus devices. as they need to access the pci devices

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-02 Thread Rafael J. Wysocki
On Thursday, January 02, 2014 02:47:04 PM Yinghai Lu wrote: > On Tue, Dec 31, 2013 at 1:03 PM, Rafael J. Wysocki wrote: > > On Tuesday, December 31, 2013 10:45:46 AM Yinghai Lu wrote: > >> On Mon, Dec 30, 2013 at 5:15 AM, Rafael J. Wysocki > >> wrote: > >> > On Monday, December 30, 2013

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-02 Thread Yinghai Lu
On Tue, Dec 31, 2013 at 1:03 PM, Rafael J. Wysocki wrote: > On Tuesday, December 31, 2013 10:45:46 AM Yinghai Lu wrote: >> On Mon, Dec 30, 2013 at 5:15 AM, Rafael J. Wysocki >> wrote: >> > On Monday, December 30, 2013 01:51:28 PM Rafael J. Wysocki wrote: >> >> > We have patches that need to

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-02 Thread Yinghai Lu
On Tue, Dec 31, 2013 at 1:03 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Tuesday, December 31, 2013 10:45:46 AM Yinghai Lu wrote: On Mon, Dec 30, 2013 at 5:15 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday, December 30, 2013 01:51:28 PM Rafael J. Wysocki wrote: We have

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2014-01-02 Thread Rafael J. Wysocki
On Thursday, January 02, 2014 02:47:04 PM Yinghai Lu wrote: On Tue, Dec 31, 2013 at 1:03 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Tuesday, December 31, 2013 10:45:46 AM Yinghai Lu wrote: On Mon, Dec 30, 2013 at 5:15 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday,

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-31 Thread Rafael J. Wysocki
On Tuesday, December 31, 2013 10:45:46 AM Yinghai Lu wrote: > On Mon, Dec 30, 2013 at 5:15 AM, Rafael J. Wysocki wrote: > > On Monday, December 30, 2013 01:51:28 PM Rafael J. Wysocki wrote: > >> > We have patches that need to stop ioapic and iommu between > >> > pci_stop_root_bus and

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-31 Thread Yinghai Lu
On Mon, Dec 30, 2013 at 5:15 AM, Rafael J. Wysocki wrote: > On Monday, December 30, 2013 01:51:28 PM Rafael J. Wysocki wrote: >> > We have patches that need to stop ioapic and iommu between >> > pci_stop_root_bus and pci_remove_root_bus. > > BTW, what *exactly* do they need to be stopped between?

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-31 Thread Yinghai Lu
On Mon, Dec 30, 2013 at 5:15 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday, December 30, 2013 01:51:28 PM Rafael J. Wysocki wrote: We have patches that need to stop ioapic and iommu between pci_stop_root_bus and pci_remove_root_bus. BTW, what *exactly* do they need to be stopped

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-31 Thread Rafael J. Wysocki
On Tuesday, December 31, 2013 10:45:46 AM Yinghai Lu wrote: On Mon, Dec 30, 2013 at 5:15 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday, December 30, 2013 01:51:28 PM Rafael J. Wysocki wrote: We have patches that need to stop ioapic and iommu between pci_stop_root_bus and

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-30 Thread Rafael J. Wysocki
On Monday, December 30, 2013 01:51:28 PM Rafael J. Wysocki wrote: > On Sunday, December 29, 2013 07:30:18 PM Yinghai Lu wrote: > > On Sat, Dec 28, 2013 at 3:20 PM, Rafael J. Wysocki > > wrote: > > > From: Rafael J. Wysocki > > > > > > The device_del(_bridge->dev) in pci_stop_root_bus() is > > >

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-30 Thread Rafael J. Wysocki
On Sunday, December 29, 2013 07:30:18 PM Yinghai Lu wrote: > On Sat, Dec 28, 2013 at 3:20 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The device_del(_bridge->dev) in pci_stop_root_bus() is > > problematic, because it causes all sysfs directories below > > the host bridge to

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-30 Thread Rafael J. Wysocki
On Sunday, December 29, 2013 07:30:18 PM Yinghai Lu wrote: On Sat, Dec 28, 2013 at 3:20 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com The device_del(host_bridge-dev) in pci_stop_root_bus() is problematic, because it causes all sysfs

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-30 Thread Rafael J. Wysocki
On Monday, December 30, 2013 01:51:28 PM Rafael J. Wysocki wrote: On Sunday, December 29, 2013 07:30:18 PM Yinghai Lu wrote: On Sat, Dec 28, 2013 at 3:20 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com The

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-29 Thread Yinghai Lu
On Sat, Dec 28, 2013 at 3:20 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The device_del(_bridge->dev) in pci_stop_root_bus() is > problematic, because it causes all sysfs directories below > the host bridge to be removed recursively and when > pci_remove_root_bus() attempts to

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-29 Thread Yinghai Lu
On Sat, Dec 28, 2013 at 3:20 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com The device_del(host_bridge-dev) in pci_stop_root_bus() is problematic, because it causes all sysfs directories below the host bridge to be removed recursively and

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-28 Thread Greg Kroah-Hartman
On Sun, Dec 29, 2013 at 12:20:22AM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The device_del(_bridge->dev) in pci_stop_root_bus() is > problematic, because it causes all sysfs directories below > the host bridge to be removed recursively and when > pci_remove_root_bus()

[PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-28 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The device_del(_bridge->dev) in pci_stop_root_bus() is problematic, because it causes all sysfs directories below the host bridge to be removed recursively and when pci_remove_root_bus() attempts to remove devices on the root bus (whose sysfs directories are gone now

[PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-28 Thread Rafael J. Wysocki
From: Rafael J. Wysocki rafael.j.wyso...@intel.com The device_del(host_bridge-dev) in pci_stop_root_bus() is problematic, because it causes all sysfs directories below the host bridge to be removed recursively and when pci_remove_root_bus() attempts to remove devices on the root bus (whose sysfs

Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings

2013-12-28 Thread Greg Kroah-Hartman
On Sun, Dec 29, 2013 at 12:20:22AM +0100, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com The device_del(host_bridge-dev) in pci_stop_root_bus() is problematic, because it causes all sysfs directories below the host bridge to be removed recursively and when