Re: [PATCH][v3] xhci: correctly enable interrupts

2013-03-15 Thread Greg KH
On Tue, Mar 05, 2013 at 11:45:28AM +0100, Thomas Renninger wrote: > On Monday, March 04, 2013 05:14:43 PM Thomas Renninger wrote: > > From: Hannes Reinecke > > > > xhci has its own interrupt enabling routine, which will try to > > use MSI-X/MSI if present. So the usb core shouldn't try to enable

Re: [PATCH][v3] xhci: correctly enable interrupts

2013-03-05 Thread Sarah Sharp
Looks fine on the xHCI portion. Thanks for catching the XHCI_BROKEN_MSI case. Acked-by: Sarah Sharp On Mon, Mar 04, 2013 at 05:14:43PM +0100, Thomas Renninger wrote: > From: Hannes Reinecke > > xhci has its own interrupt enabling routine, which will try to > use MSI-X/MSI if present. So the u

Re: [PATCH][v3] xhci: correctly enable interrupts

2013-03-05 Thread Thomas Renninger
On Monday, March 04, 2013 05:14:43 PM Thomas Renninger wrote: > From: Hannes Reinecke > > xhci has its own interrupt enabling routine, which will try to > use MSI-X/MSI if present. So the usb core shouldn't try to enable > legacy interrupts; on some machines the xhci legacy IRQ setting > is inval

Re: [PATCH][v3] xhci: correctly enable interrupts

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Sergei Shtylyov wrote: > > @@ -371,6 +371,7 @@ static int xhci_try_enable_msi(struct usb_hcd *hcd) > > return -EINVAL; > > } > > > > + legacy_irq: > > > > Labels shouldn't be indented by a space (unless the existing coding > style has them indented alr

Re: [PATCH][v3] xhci: correctly enable interrupts

2013-03-04 Thread Sergei Shtylyov
Hello. On 03/04/2013 07:14 PM, Thomas Renninger wrote: From: Hannes Reinecke xhci has its own interrupt enabling routine, which will try to use MSI-X/MSI if present. So the usb core shouldn't try to enable legacy interrupts; on some machines the xhci legacy IRQ setting is invalid. v3: Be care

[PATCH][v3] xhci: correctly enable interrupts

2013-03-04 Thread Thomas Renninger
From: Hannes Reinecke xhci has its own interrupt enabling routine, which will try to use MSI-X/MSI if present. So the usb core shouldn't try to enable legacy interrupts; on some machines the xhci legacy IRQ setting is invalid. v3: Be careful to not break XHCI_BROKEN_MSI workaround (by trenn) Cc