Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c

2007-10-10 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > this crashes during bootup - removed it for now. > > > > Boots here and also survived LTP and some other tests. Hmm; i had an > > early version that hung because I forgot a break. Perhaps I forgot > > quilt refresh. Can you check you have this ver

Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c

2007-10-10 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > > this crashes during bootup - removed it for now. > > Boots here and also survived LTP and some other tests. Hmm; i had an > early version that hung because I forgot a break. Perhaps I forgot > quilt refresh. Can you check you have this version? hm,

Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c

2007-10-09 Thread Andi Kleen
On Tue, Oct 09, 2007 at 09:17:31PM +0200, Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > No need to be more spagetti than absolutely necessary. > > > > Replace loops implemented with gotos with real loops. Replace err = > > ...; goto x; x: return err; with return ...; > >

Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c

2007-10-09 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > No need to be more spagetti than absolutely necessary. > > Replace loops implemented with gotos with real loops. Replace err = > ...; goto x; x: return err; with return ...; > > No functional changes. this crashes during bootup - removed it for now.

Re: [PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c

2007-10-08 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > No need to be more spagetti than absolutely necessary. > > Replace loops implemented with gotos with real loops. Replace err = > ...; goto x; x: return err; with return ...; > > No functional changes. thanks, applied. Ingo - To unsubscribe fr

[PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c

2007-10-07 Thread Andi Kleen
No need to be more spagetti than absolutely necessary. Replace loops implemented with gotos with real loops. Replace err = ...; goto x; x: return err; with return ...; No functional changes. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux-2.6-sched-devel/kernel/sched.c