Re: [PATCH] [1/9] Handle kernel near memory hole in clear_kernel_mapping

2008-01-31 Thread Andi Kleen
> > +#define overlaps(as, ae, bs, be) ((ae) >= (bs) && (as) <= (be)) > > inline function please and a bit more intuituive arrangement of > arguments. Which one do you prefer? (to be honest the current one is "intuitive" to me) > > > +void __init clear_kernel_mapping(unsigned long address, uns

Re: [PATCH] [1/9] Handle kernel near memory hole in clear_kernel_mapping

2008-01-31 Thread Thomas Gleixner
On Tue, 29 Jan 2008, Andi Kleen wrote: > This was a long standing obscure problem in the relocatable kernel. The > AMD GART driver needs to unmap part of the GART in the kernel direct mapping > to > prevent cache corruption. With the relocatable kernel it is in theory > possible > that the sepa

[PATCH] [1/9] Handle kernel near memory hole in clear_kernel_mapping

2008-01-28 Thread Andi Kleen
This was a long standing obscure problem in the relocatable kernel. The AMD GART driver needs to unmap part of the GART in the kernel direct mapping to prevent cache corruption. With the relocatable kernel it is in theory possible that the separate kernel text mapping straddles that area too.