Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread David Rientjes
On Thu, 19 Jul 2007, Yinghai Lu wrote: > > Index: linux/arch/x86_64/mm/srat.c > > === > > --- linux.orig/arch/x86_64/mm/srat.c > > +++ linux/arch/x86_64/mm/srat.c > > /* maps to convert between proximity domain and logical node ID */

Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread Andi Kleen
> " > * For initialized data: > * You should insert __initdata between the variable name and equal > * sign followed by value, e.g.: > * > * static int init_variable __initdata = 0; > * static char linux_logo[] __initdata = { 0x32, 0x36, ... }; > " > > or we need to update these lines? Thi

Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread Yinghai Lu
On 7/19/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > do we need to put __initdata just before =? AFAIK gcc __attribute__ syntax allows both. It certainly seems to compile. in include/linux/init.h it said " * For initialized data: * You should insert __initdata between the variable name and e

Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread Andi Kleen
> do we need to put __initdata just before =? AFAIK gcc __attribute__ syntax allows both. It certainly seems to compile. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread Yinghai Lu
On 7/19/07, Andi Kleen <[EMAIL PROTECTED]> wrote: From: David Rientjes <[EMAIL PROTECTED]> In acpi_scan_nodes(), we immediately return -1 if acpi_numa <= 0, meaning we haven't detected any underlying ACPI topology or we have explicitly disabled its use from the command-line with numa=noacpi. ac

[PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread Andi Kleen
From: David Rientjes <[EMAIL PROTECTED]> In acpi_scan_nodes(), we immediately return -1 if acpi_numa <= 0, meaning we haven't detected any underlying ACPI topology or we have explicitly disabled its use from the command-line with numa=noacpi. acpi_table_print_srat_entry() and acpi_table_parse_sra