Re: [PATCH] [8/12] x86_64: Use global flag to disable broken local apic timer on AMD CPUs.

2007-08-09 Thread Andi Kleen
> > /* > > * The local apic timer can be disabled via the kernel > > * commandline or from the test above. Register the lapic > > Andi, just noticed that the comment above needs to be updated now. Too late now. I can do that as a follow up patch. It'll be hardly a showstopper. -A

Re: [PATCH] [8/12] x86_64: Use global flag to disable broken local apic timer on AMD CPUs.

2007-08-09 Thread Cal Peake
On Thu, 9 Aug 2007, Andi Kleen wrote: > Index: linux/arch/i386/kernel/apic.c > === > --- linux.orig/arch/i386/kernel/apic.c > +++ linux/arch/i386/kernel/apic.c > @@ -61,8 +61,9 @@ static int enable_local_apic __initdata > > /* Loc

[PATCH] [8/12] x86_64: Use global flag to disable broken local apic timer on AMD CPUs.

2007-08-09 Thread Andi Kleen
The Averatec 2370 and some other Turion laptop BIOS seems to program the ENABLE_C1E MSR inconsistently between cores. This confuses the lapic use heuristics because when C1E is enabled anywhere it seems to affect the complete chip. Use a global flag instead of a per cpu flag to handle this. If a