Re: [PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code

2008-01-03 Thread Andi Kleen
On Thursday 03 January 2008 11:39:12 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > It is not really useful to lock machine checks against oopses. And > > machine checks normally don't nest, so they don't need their own > > locking. Just call bust_spinlock/console_verbose

Re: [PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code

2008-01-03 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > It is not really useful to lock machine checks against oopses. And > machine checks normally don't nest, so they don't need their own > locking. Just call bust_spinlock/console_verbose directly. is this in response to any particular incident you've see

[PATCH] [9/20] x86: Don't use oops_begin in 64bit mce code

2008-01-02 Thread Andi Kleen
It is not really useful to lock machine checks against oopses. And machine checks normally don't nest, so they don't need their own locking. Just call bust_spinlock/console_verbose directly. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mcheck/mce_64.c |3 ++- 1 fil