Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-31 Thread Andi Kleen
On Thu, Jan 31, 2008 at 06:10:02PM +0100, Thomas Gleixner wrote: > On Thu, 31 Jan 2008, Andi Kleen wrote: > > > On Thu, Jan 31, 2008 at 05:17:41PM +0100, Thomas Gleixner wrote: > > > On Tue, 29 Jan 2008, Andi Kleen wrote: > > > > > > > > +static unsigned long direct_entry(unsigned long paddr) > >

Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-31 Thread Thomas Gleixner
On Thu, 31 Jan 2008, Andi Kleen wrote: > On Thu, Jan 31, 2008 at 05:17:41PM +0100, Thomas Gleixner wrote: > > On Tue, 29 Jan 2008, Andi Kleen wrote: > > > > > > +static unsigned long direct_entry(unsigned long paddr) > > > > Please use a more sensible function name. This one has no association >

Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-31 Thread Andi Kleen
On Thu, Jan 31, 2008 at 05:17:41PM +0100, Thomas Gleixner wrote: > On Tue, 29 Jan 2008, Andi Kleen wrote: > > > > +static unsigned long direct_entry(unsigned long paddr) > > Please use a more sensible function name. This one has no association > with the functionality at all. Can you suggest

Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-31 Thread Thomas Gleixner
On Tue, 29 Jan 2008, Andi Kleen wrote: > > +static unsigned long direct_entry(unsigned long paddr) Please use a more sensible function name. This one has no association with the functionality at all. > +{ > + unsigned long entry; New line please > + entry = __PAGE_KERNEL_LARGE|paddr; >

Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-31 Thread Thomas Gleixner
On Tue, 29 Jan 2008, Andi Kleen wrote: +static unsigned long direct_entry(unsigned long paddr) Please use a more sensible function name. This one has no association with the functionality at all. +{ + unsigned long entry; New line please + entry = __PAGE_KERNEL_LARGE|paddr; +

Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-31 Thread Andi Kleen
On Thu, Jan 31, 2008 at 05:17:41PM +0100, Thomas Gleixner wrote: On Tue, 29 Jan 2008, Andi Kleen wrote: +static unsigned long direct_entry(unsigned long paddr) Please use a more sensible function name. This one has no association with the functionality at all. Can you suggest one? I

Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-31 Thread Thomas Gleixner
On Thu, 31 Jan 2008, Andi Kleen wrote: On Thu, Jan 31, 2008 at 05:17:41PM +0100, Thomas Gleixner wrote: On Tue, 29 Jan 2008, Andi Kleen wrote: +static unsigned long direct_entry(unsigned long paddr) Please use a more sensible function name. This one has no association with the

Re: [PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-31 Thread Andi Kleen
On Thu, Jan 31, 2008 at 06:10:02PM +0100, Thomas Gleixner wrote: On Thu, 31 Jan 2008, Andi Kleen wrote: On Thu, Jan 31, 2008 at 05:17:41PM +0100, Thomas Gleixner wrote: On Tue, 29 Jan 2008, Andi Kleen wrote: +static unsigned long direct_entry(unsigned long paddr) Please use

[PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-28 Thread Andi Kleen
This should decrease TLB pressure because the kernel will need less TLB faults for its own data access. Only done for 64bit because i386 does not support GB page tables. This only applies to the data portion of the direct mapping; the kernel text mapping stays with 2MB pages because the AMD

[PATCH] [9/9] GBPAGES: Do kernel direct mapping at boot using GB pages

2008-01-28 Thread Andi Kleen
This should decrease TLB pressure because the kernel will need less TLB faults for its own data access. Only done for 64bit because i386 does not support GB page tables. This only applies to the data portion of the direct mapping; the kernel text mapping stays with 2MB pages because the AMD