Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-05-12 Thread Eric Paris
On Thu, 2013-05-09 at 09:29 -0400, Steve Grubb wrote: > On Tuesday, April 16, 2013 03:38:23 PM Richard Guy Briggs wrote: > > On Tue, Apr 09, 2013 at 02:39:32AM -0700, Eric W. Biederman wrote: > > > Andrew Morton writes: > > > > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs > wrote: > > >

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-05-09 Thread Richard Guy Briggs
On Thu, May 09, 2013 at 09:52:47AM -0400, Richard Guy Briggs wrote: > On Thu, May 09, 2013 at 09:29:18AM -0400, Steve Grubb wrote: > > On Tuesday, April 16, 2013 03:38:23 PM Richard Guy Briggs wrote: > > > On Tue, Apr 09, 2013 at 02:39:32AM -0700, Eric W. Biederman wrote: > > > > Andrew Morton wri

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-05-09 Thread Richard Guy Briggs
On Thu, May 09, 2013 at 09:29:18AM -0400, Steve Grubb wrote: > On Tuesday, April 16, 2013 03:38:23 PM Richard Guy Briggs wrote: > > On Tue, Apr 09, 2013 at 02:39:32AM -0700, Eric W. Biederman wrote: > > > Andrew Morton writes: > > > > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs > wrote

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-05-09 Thread Steve Grubb
On Tuesday, April 16, 2013 03:38:23 PM Richard Guy Briggs wrote: > On Tue, Apr 09, 2013 at 02:39:32AM -0700, Eric W. Biederman wrote: > > Andrew Morton writes: > > > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs wrote: > > >> audit rule additions containing "-F auid!=4294967295" were fai

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-16 Thread Richard Guy Briggs
On Tue, Apr 09, 2013 at 02:39:32AM -0700, Eric W. Biederman wrote: > Andrew Morton writes: > > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs > > wrote: > >> audit rule additions containing "-F auid!=4294967295" were failing with > >> EINVAL. > > The only case where this appears to make

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-10 Thread Richard Guy Briggs
On Wed, Apr 10, 2013 at 11:02:43AM -0700, Eric W. Biederman wrote: > Richard Guy Briggs writes: > > On Tue, Apr 09, 2013 at 02:39:32AM -0700, Eric W. Biederman wrote: > >> @@ -377,6 +383,12 @@ static struct audit_entry *audit_rule_to_entry(struct > >> audit_rule *rule) > >>if

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-10 Thread Eric W. Biederman
Richard Guy Briggs writes: > On Tue, Apr 09, 2013 at 02:39:32AM -0700, Eric W. Biederman wrote: >> @@ -377,6 +383,12 @@ static struct audit_entry *audit_rule_to_entry(struct >> audit_rule *rule) >> if (!gid_valid(f->gid)) >> goto exit_free; >>

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-10 Thread Richard Guy Briggs
On Wed, Apr 10, 2013 at 12:20:18PM -0400, Richard Guy Briggs wrote: > On Tue, Apr 09, 2013 at 02:16:22PM -0700, Eric W. Biederman wrote: > > Steve Grubb writes: > > > On Tuesday, April 09, 2013 02:39:32 AM Eric W. Biederman wrote: > > >> Andrew Morton writes: > > >> > On Wed, 20 Mar 2013 15:18:17

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-10 Thread Richard Guy Briggs
On Tue, Apr 09, 2013 at 02:16:22PM -0700, Eric W. Biederman wrote: > Steve Grubb writes: > > > On Tuesday, April 09, 2013 02:39:32 AM Eric W. Biederman wrote: > >> Andrew Morton writes: > >> > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs > > wrote: > >> >> audit rule additions contain

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-09 Thread Eric W. Biederman
Steve Grubb writes: > On Tuesday, April 09, 2013 02:39:32 AM Eric W. Biederman wrote: >> Andrew Morton writes: >> > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs > wrote: >> >> audit rule additions containing "-F auid!=4294967295" were failing with >> >> EINVAL. >> >> >> >> UID_INVALI

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-09 Thread Steve Grubb
On Tuesday, April 09, 2013 02:39:32 AM Eric W. Biederman wrote: > Andrew Morton writes: > > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs wrote: > >> audit rule additions containing "-F auid!=4294967295" were failing with > >> EINVAL. > >> > >> UID_INVALID (and GID_INVALID) is actually

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-09 Thread Richard Guy Briggs
On Tue, Apr 09, 2013 at 02:39:32AM -0700, Eric W. Biederman wrote: > Andrew Morton writes: > > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs > > wrote: > >> audit rule additions containing "-F auid!=4294967295" were failing with > >> EINVAL. > >> > >> UID_INVALID (and GID_INVALID) is a

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-09 Thread Eric W. Biederman
Andrew Morton writes: > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs wrote: > >> audit rule additions containing "-F auid!=4294967295" were failing with >> EINVAL. >> >> UID_INVALID (and GID_INVALID) is actually a valid uid (gid) for setting and >> testing against audit rules. Remove

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-08 Thread Andrew Morton
On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs wrote: > audit rule additions containing "-F auid!=4294967295" were failing with > EINVAL. > > UID_INVALID (and GID_INVALID) is actually a valid uid (gid) for setting and > testing against audit rules. Remove the check for invalid uid and g

[PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-03-20 Thread Richard Guy Briggs
audit rule additions containing "-F auid!=4294967295" were failing with EINVAL. UID_INVALID (and GID_INVALID) is actually a valid uid (gid) for setting and testing against audit rules. Remove the check for invalid uid and gid when parsing rules and data for logging. Revert part of ca57ec0f00c3f1