Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread Peter Zijlstra
On Tue, Apr 10, 2018 at 08:14:54AM -0700, Joe Perches wrote: > Whinging about bool : seems entirely sensible > and straightforward to do. > > I'm not so sure about bool in structs as a patch context > could be adding a bool to local stack definitions and > there's no real ability to determine if

Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread Joe Perches
On Tue, 2018-04-10 at 14:33 +0200, Peter Zijlstra wrote: > On Tue, Apr 10, 2018 at 10:00:01AM +0200, Rafael J. Wysocki wrote: > > On Tue, Apr 10, 2018 at 9:33 AM, wrote: > > > +++ b/kernel/time/tick-sched.h > > > @@ -48,8 +48,8 @@ struct tick_sched { > > > unsigned long

Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread Peter Zijlstra
On Tue, Apr 10, 2018 at 10:00:01AM +0200, Rafael J. Wysocki wrote: > On Tue, Apr 10, 2018 at 9:33 AM, wrote: > > +++ b/kernel/time/tick-sched.h > > @@ -48,8 +48,8 @@ struct tick_sched { > > unsigned long check_clocks; > > enum tick_nohz_mode nohz_mode

Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread Thomas Gleixner
On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > On 2018-04-10 04:00 PM, Rafael J. Wysocki wrote: > > On Tue, Apr 10, 2018 at 9:33 AM, wrote: > > > From: John Zhao > > > > > > Variable tick_stopped returned by tick_nohz_tick_stopped > > > can have only true / forse values. Since the return

Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread yuankuiz
On 2018-04-10 04:00 PM, Rafael J. Wysocki wrote: On Tue, Apr 10, 2018 at 9:33 AM, wrote: From: John Zhao Variable tick_stopped returned by tick_nohz_tick_stopped can have only true / forse values. Since the return type of the tick_nohz_tick_stopped is also bool, variable tick_stopped nice to

Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread yuankuiz
On 2018-04-10 03:55 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: From: John Zhao Variable tick_stopped returned by tick_nohz_tick_stopped can have only true / forse values. Since the return type of the tick_nohz_tick_stopped is also bool, variable tick_stoppe

Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread Rafael J. Wysocki
On Tue, Apr 10, 2018 at 9:33 AM, wrote: > From: John Zhao > > Variable tick_stopped returned by tick_nohz_tick_stopped > can have only true / forse values. Since the return type > of the tick_nohz_tick_stopped is also bool, variable > tick_stopped nice to have data type as bool in place of int.

Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread Thomas Gleixner
On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > From: John Zhao > > Variable tick_stopped returned by tick_nohz_tick_stopped > can have only true / forse values. Since the return type > of the tick_nohz_tick_stopped is also bool, variable > tick_stopped nice to have data type as bool in pl

[PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread yuankuiz
From: John Zhao Variable tick_stopped returned by tick_nohz_tick_stopped can only be true / false values. Since the return type of the tick_nohz_tick_stopped is also bool, variable tick_stopped nice to have data type as bool in place of int. Moreover, the executed instructions cost could be mini

Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped

2018-04-10 Thread yuankuiz
From: John Zhao Variable tick_stopped returned by tick_nohz_tick_stopped can have only true / forse values. Since the return type of the tick_nohz_tick_stopped is also bool, variable tick_stopped nice to have data type as bool in place of int. Moreover, the executed instructions cost could be mi