Re: [PATCH] [PATCH] usbnet: code clean up using checkpatch

2012-08-31 Thread David Miller
From: Oliver Neukum Date: Thu, 30 Aug 2012 20:58:42 +0200 > Dave, > > please don't take this patch. It changes code and breaks the driver. > A great big NACK. He didn't send it to netdev so I would have ignored it anyways. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH] [PATCH] usbnet: code clean up using checkpatch

2012-08-30 Thread Oliver Neukum
On Thursday 30 August 2012 20:18:41 SeungGoo, Kim wrote: > @@ -748,8 +752,9 @@ int usbnet_open (struct net_device *net) > goto done_nopm; > } > > - // put into "known safe" state > - if (info->reset && (retval = info->reset (dev)) < 0) { > + /* put into "

[PATCH] [PATCH] usbnet: code clean up using checkpatch

2012-08-30 Thread SeungGoo, Kim
Signed-off-by: SeungGoo, Kim --- drivers/net/usb/usbnet.c | 522 +++-- 1 files changed, 267 insertions(+), 255 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 8531c1c..91bd08e 100644 --- a/drivers/net/usb/usbnet.c +++ b