Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-05-27 Thread Nga Chi
On Thu, May 28, 2015 at 9:32 AM, Brian Norris wrote: > Hi Nga, > > Sorry for some delay here. This driver is mostly pretty good, and I > think only a few very small tweaks are needed. > > (BTW, Rafal already made a few tiny comments, and I didn't see a follow > up that fixes any of them.) Thanks

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-05-27 Thread Brian Norris
Hi Nga, Sorry for some delay here. This driver is mostly pretty good, and I think only a few very small tweaks are needed. (BTW, Rafal already made a few tiny comments, and I didn't see a follow up that fixes any of them.) On Mon, Mar 16, 2015 at 01:16:22AM -0700, vn...@altera.com wrote: > From:

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-05-04 Thread Viet Nga Dao
Hi, It has been long time since this patch was up. Could you please help me to review? Thanks, Viet Nga On Thu, Apr 23, 2015 at 2:39 PM, Nga Chi wrote: > Hi Brian, > Could you please spend some time help me to review this patch? It has > been more than 1 month and i really hope can get this patch

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-04-22 Thread Nga Chi
Hi Brian, Could you please spend some time help me to review this patch? It has been more than 1 month and i really hope can get this patch upstream by end of this month. Thanks, Viet Nga On Mon, Mar 16, 2015 at 4:16 PM, wrote: > From: VIET NGA DAO > > Altera Quad SPI Controller is a soft IP wh

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-04-14 Thread Viet Nga Dao
Hi, Could you please help me to review this patch? Thanks On Mon, Mar 16, 2015 at 4:40 PM, Viet Nga Dao wrote: > On Mon, Mar 16, 2015 at 4:35 PM, Rafał Miłecki wrote: >> On 16 March 2015 at 09:16, wrote: >>> +static struct flash_device flash_devices[] = { >>> + FLASH_ID("epcq16-nonjedec"

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-04-07 Thread Viet Nga Dao
Hi Brian, Can you help me to review this patch of mine? Thanks, Nga On Mon, Mar 16, 2015 at 4:16 PM, wrote: > From: VIET NGA DAO > > Altera Quad SPI Controller is a soft IP which enables access to Altera EPCQ > and > EPCS flash chips. This patch adds driver for these devices. > > Signed-off-by

[PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-03-16 Thread vndao
From: VIET NGA DAO Altera Quad SPI Controller is a soft IP which enables access to Altera EPCQ and EPCS flash chips. This patch adds driver for these devices. Signed-off-by: VIET NGA DAO --- v3: - Change altera_epcq driver name to altera_quadspi for more generic name - Implement flash name sea

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-03-16 Thread Viet Nga Dao
On Mon, Mar 16, 2015 at 4:35 PM, Rafał Miłecki wrote: > On 16 March 2015 at 09:16, wrote: >> +static struct flash_device flash_devices[] = { >> + FLASH_ID("epcq16-nonjedec", 2, 0x15), >> + FLASH_ID("epcq32-nonjedec", 2, 0x16), >> + FLASH_ID("epcq64-nonjedec", 2, 0x17), >> +

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-03-16 Thread Rafał Miłecki
On 16 March 2015 at 09:16, wrote: > +static struct flash_device flash_devices[] = { > + FLASH_ID("epcq16-nonjedec", 2, 0x15), > + FLASH_ID("epcq32-nonjedec", 2, 0x16), > + FLASH_ID("epcq64-nonjedec", 2, 0x17), > + FLASH_ID("epcq128-nonjedec", 2, 0x18), > + FLASH_I