RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Alan Stern
On Fri, 19 Jul 2013, Gioh Kim wrote: > > I was going to ask the same question. This particular piece of code gets > > executed _only_ when an URB is unlinked. Not during any other kind of > > error. > > > I've got the problem when I listened to the mp3 file of USB HDD. > I checked the urb

RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Gioh Kim
e.com; Minchan Kim; Chanho Min; Jong-Sung Kim; > linux-arm-kernel > Subject: Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next > > On Thu, 18 Jul 2013, Ming Lei wrote: > > > > I guess that HC could have a use-after-free problem like following > situation. > &

RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Gioh Kim
; Jong-Sung Kim; linux-arm-kernel Subject: Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next On Thu, 18 Jul 2013, Ming Lei wrote: I guess that HC could have a use-after-free problem like following situation. 1. A qtd which is not at the queue head should be removed

RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Alan Stern
On Fri, 19 Jul 2013, Gioh Kim wrote: I was going to ask the same question. This particular piece of code gets executed _only_ when an URB is unlinked. Not during any other kind of error. I've got the problem when I listened to the mp3 file of USB HDD. I checked the urb data when the

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-18 Thread Ming Lei
On Thu, Jul 18, 2013 at 10:08 PM, Alan Stern wrote: > On Thu, 18 Jul 2013, Ming Lei wrote: > >> > I guess that HC could have a use-after-free problem like following >> > situation. >> > >> > 1. A qtd which is not at the queue head should be removed in >> > qh_completions(). >> > 2. The

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-18 Thread Alan Stern
On Thu, 18 Jul 2013, Ming Lei wrote: > > I guess that HC could have a use-after-free problem like following > > situation. > > > > 1. A qtd which is not at the queue head should be removed in > > qh_completions(). > > 2. The last->hw_next become be pointing at the next qtd but the hw_next > >

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-18 Thread Ming Lei
inux-kernel@vger.kernel.org; >> Mark Salter; namhyung@lge.com; Minchan Kim; Chanho Min; Jong-Sung Kim; >> linux-arm-kernel >> Subject: Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next >> >> Cc: ARM list >> >> On Wed, Jul 17, 2013 at 1:03 PM, 김

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-18 Thread Ming Lei
Salter; namhyung@lge.com; Minchan Kim; Chanho Min; Jong-Sung Kim; linux-arm-kernel Subject: Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next Cc: ARM list On Wed, Jul 17, 2013 at 1:03 PM, 김기오 gioh@lge.com wrote: Hi, I have a missing urb completion problem on ARMv7

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-18 Thread Alan Stern
On Thu, 18 Jul 2013, Ming Lei wrote: I guess that HC could have a use-after-free problem like following situation. 1. A qtd which is not at the queue head should be removed in qh_completions(). 2. The last-hw_next become be pointing at the next qtd but the hw_next value is

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-18 Thread Ming Lei
On Thu, Jul 18, 2013 at 10:08 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 18 Jul 2013, Ming Lei wrote: I guess that HC could have a use-after-free problem like following situation. 1. A qtd which is not at the queue head should be removed in qh_completions(). 2. The

RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-17 Thread Gioh Kim
nho Min; Jong-Sung Kim; > linux-arm-kernel > Subject: Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next > > Cc: ARM list > > On Wed, Jul 17, 2013 at 1:03 PM, 김기오 wrote: > > Hi, > > > > I have a missing urb completion problem on ARMv7 based pl

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-17 Thread Ming Lei
Cc: ARM list On Wed, Jul 17, 2013 at 1:03 PM, 김기오 wrote: > Hi, > > I have a missing urb completion problem on ARMv7 based platform. > > I thought the above problem was caused by coherent memory between the > EHCI device and CPU so I tryied to allocates device type memory > for EHCI via

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-17 Thread Ming Lei
Cc: ARM list On Wed, Jul 17, 2013 at 1:03 PM, 김기오 gioh@lge.com wrote: Hi, I have a missing urb completion problem on ARMv7 based platform. I thought the above problem was caused by coherent memory between the EHCI device and CPU so I tryied to allocates device type memory for EHCI via

RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-17 Thread Gioh Kim
; linux-arm-kernel Subject: Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next Cc: ARM list On Wed, Jul 17, 2013 at 1:03 PM, 김기오 gioh@lge.com wrote: Hi, I have a missing urb completion problem on ARMv7 based platform. I thought the above problem was caused

[PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-16 Thread 김기오
Hi, I have a missing urb completion problem on ARMv7 based platform. I thought the above problem was caused by coherent memory between the EHCI device and CPU so I tryied to allocates device type memory for EHCI via dma_declare_coherent_memory at machine initialization step so that EHCI always

[PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-16 Thread 김기오
Hi, I have a missing urb completion problem on ARMv7 based platform. I thought the above problem was caused by coherent memory between the EHCI device and CPU so I tryied to allocates device type memory for EHCI via dma_declare_coherent_memory at machine initialization step so that EHCI always