Re: [PATCH] [RFC] cgroup: reject cgroup names with non-printing characters

Hello, Alban. Sorry about the delay. On Mon, Jul 21, 2014 at 04:11:56PM +0100, Alban Crequy wrote: > @@ -4387,6 +4401,11 @@ static int cgroup_mkdir(struct kernfs_node *parent_kn, > const char *name, > struct kernfs_node *kn; > int ssid, ret; > > + /* do not create cgroups with

[PATCH] [RFC] cgroup: reject cgroup names with non-printing characters

/proc//cgroup contains one cgroup path on each line. If cgroup names are allowed to contain "\n", applications cannot parse /proc//cgroup safely. I use < 0x20 as seen in vfat_bad_char; is it safe to use isprint()? Signed-off-by: Alban Crequy --- kernel/cgroup.c | 19 +++ 1 file