Re: [PATCH] [RFC] x86/cpu: Fix SMAP check in PVOPS environments

2015-04-21 Thread Rusty Russell
Andy Lutomirski writes: > On 04/20/2015 10:09 AM, Andrew Cooper wrote: >> There appears to be no formal statement of what pv_irq_ops.save_fl() is >> supposed to return precisely. Native returns the full flags, while lguest >> and >> Xen only return the Interrupt Flag, and both have comments by t

Re: [Xen-devel] [PATCH] [RFC] x86/cpu: Fix SMAP check in PVOPS environments

2015-04-21 Thread Jan Beulich
>>> On 20.04.15 at 19:09, wrote: > A different approach, given the dual nature of the AC flag now is to gate > setup_smap() on a kernel rpl of 0. SMAP necessarily can't be used in a > paravirtual situation where the kernel runs in cpl > 0. "Can't" isn't true here - for 64-bit PV Xen guests, whic

Re: [PATCH] [RFC] x86/cpu: Fix SMAP check in PVOPS environments

2015-04-21 Thread Andrew Cooper
On 21/04/2015 01:35, Andy Lutomirski wrote: > On 04/20/2015 10:09 AM, Andrew Cooper wrote: >> There appears to be no formal statement of what pv_irq_ops.save_fl() is >> supposed to return precisely. Native returns the full flags, while >> lguest and >> Xen only return the Interrupt Flag, and both

Re: [PATCH] [RFC] x86/cpu: Fix SMAP check in PVOPS environments

2015-04-20 Thread Andy Lutomirski
On 04/20/2015 10:09 AM, Andrew Cooper wrote: There appears to be no formal statement of what pv_irq_ops.save_fl() is supposed to return precisely. Native returns the full flags, while lguest and Xen only return the Interrupt Flag, and both have comments by the implementations stating that only t

Re: [PATCH] [RFC] x86/cpu: Fix SMAP check in PVOPS environments

2015-04-20 Thread David Vrabel
On 20/04/15 18:09, Andrew Cooper wrote: > There appears to be no formal statement of what pv_irq_ops.save_fl() is > supposed to return precisely. Native returns the full flags, while lguest and > Xen only return the Interrupt Flag, and both have comments by the > implementations stating that only

[PATCH] [RFC] x86/cpu: Fix SMAP check in PVOPS environments

2015-04-20 Thread Andrew Cooper
There appears to be no formal statement of what pv_irq_ops.save_fl() is supposed to return precisely. Native returns the full flags, while lguest and Xen only return the Interrupt Flag, and both have comments by the implementations stating that only the Interrupt Flag is looked at. This may have