Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-22 Thread Ming Lei
On Thu, Nov 22, 2012 at 10:15 AM, Solomon Peachy wrote: > On Thu, Nov 22, 2012 at 09:45:23AM +0800, Ming Lei wrote: >> No, it is not related closely, CONFIG_FIRMWARE_IN_KERNEL means >> that all in-kernel-tree firmware blobs should be included in kernel binary, >> but CONFIG_EXTRA_FIRMARE means tha

Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-22 Thread Solomon Peachy
On Thu, Nov 22, 2012 at 09:45:23AM +0800, Ming Lei wrote: > No, it is not related closely, CONFIG_FIRMWARE_IN_KERNEL means > that all in-kernel-tree firmware blobs should be included in kernel binary, > but CONFIG_EXTRA_FIRMARE means that one additional firmware > image will be put into kernel bina

Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-22 Thread Ming Lei
On Wed, Nov 21, 2012 at 10:01 PM, Solomon Peachy wrote: > On Wed, Nov 21, 2012 at 09:35:28AM +0800, Ming Lei wrote: >> Solomon, I can't duplicate the build failure with your .config on >> 3.7-rc5-next. > > Okay, so it's since been fixed. > >> > * The #ifdef wraps code that pertains solely to bui

Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-21 Thread Solomon Peachy
On Wed, Nov 21, 2012 at 09:35:28AM +0800, Ming Lei wrote: > Solomon, I can't duplicate the build failure with your .config on > 3.7-rc5-next. Okay, so it's since been fixed. > > * The #ifdef wraps code that pertains solely to built-in firmware, (ie > >CONFIG_FIRMWARE_IN_KERNEL) and has a

Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-20 Thread Ming Lei
On Tue, 20 Nov 2012 13:12:03 -0500 Solomon Peachy wrote: > On Tue, Nov 20, 2012 at 08:33:09AM -0800, Greg KH wrote: > > > The corresponding .config is attached. Note that it is for a uClinux > > > 3.3.0-uc0 kernel. > > > > Lots of things have changed in the firmware code since 3.3.0, can you >

Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-20 Thread Solomon Peachy
On Tue, Nov 20, 2012 at 08:33:09AM -0800, Greg KH wrote: > > The corresponding .config is attached. Note that it is for a uClinux > > 3.3.0-uc0 kernel. > > Lots of things have changed in the firmware code since 3.3.0, can you > retest this on the 3.7-rc6 tree? Not easily; My employer is contrac

Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-20 Thread Greg KH
On Tue, Nov 20, 2012 at 11:10:11AM -0500, Solomon Peachy wrote: > On Wed, Nov 21, 2012 at 12:01:40AM +0800, Ming Lei wrote: > > > drivers/built-in.o: In function `release_firmware': > > > (.text+0x192e2): undefined reference to `__end_builtin_fw' > > > drivers/built-in.o: In function `release_firmw

Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-20 Thread Solomon Peachy
On Wed, Nov 21, 2012 at 12:01:40AM +0800, Ming Lei wrote: > > drivers/built-in.o: In function `release_firmware': > > (.text+0x192e2): undefined reference to `__end_builtin_fw' > > drivers/built-in.o: In function `release_firmware': > > (.text+0x19304): undefined reference to `__end_builtin_fw' > >

Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-20 Thread Ming Lei
On Tue, Nov 20, 2012 at 10:45 PM, Solomon Peachy wrote: > When compiling the firmware loader, the builtin firmware functions were > erroneously compiled as they were wrapped with CONFIG_FW_LOADER instead > of CONFIG_FIRMWARE_IN_KERNEL. This is normally harmless, except when > there was actually n

[PATCH] [firmware_class] Fix compile with no builtin firmware

2012-11-20 Thread Solomon Peachy
When compiling the firmware loader, the builtin firmware functions were erroneously compiled as they were wrapped with CONFIG_FW_LOADER instead of CONFIG_FIRMWARE_IN_KERNEL. This is normally harmless, except when there was actually no firmware to compile into the kernel, causing the build to fail