Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-04-08 Thread Ken Moffat
On Wed, Apr 03, 2013 at 07:49:48PM -0400, Jeff Garzik wrote: > > applied the version from Krzysztof Mazur, which covered both cases > > According to linus's changelog for -rc6, this doesn't seem to have been included ? ken -- das eine Mal als Tragödie, das andere Mal als Farce -- To unsubscri

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-04-04 Thread Gwendal Grignou
Thank you. Gwendal. On Wed, Apr 3, 2013 at 4:49 PM, Jeff Garzik wrote: > On 03/29/2013 01:56 AM, Gwendal Grignou wrote: >> >> commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key >> used for returning task registers, but HDIO_DRIVE_CMD ioctl was >> not changed accordingly. >> >>

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-04-03 Thread Jeff Garzik
On 03/29/2013 01:56 AM, Gwendal Grignou wrote: commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO. Signe

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Ken Moffat
On Fri, Mar 29, 2013 at 08:34:43PM +, Ken Moffat wrote: > On Fri, Mar 29, 2013 at 06:31:03PM +, Ken Moffat wrote: > I've no idea about the details, but it looks to me as if smartd is > still getting different values returned to it. The capability check > normally was ok (silent), the aut

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Ken Moffat
On Fri, Mar 29, 2013 at 06:31:03PM +, Ken Moffat wrote: > On Thu, Mar 28, 2013 at 10:56:49PM -0700, Gwendal Grignou wrote: > > Hmm, not sure. Smartd started and was happy to monitor the disk, > but I got two new messages between 'found in smartd database' and > 'is SMART capable. Adding to "

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Ken Moffat
On Thu, Mar 28, 2013 at 10:56:49PM -0700, Gwendal Grignou wrote: Hmm, not sure. Smartd started and was happy to monitor the disk, but I got two new messages between 'found in smartd database' and 'is SMART capable. Adding to "monitor" list' - Mar 29 17:26:42 ac4tv smartd[2481]: Device: /dev/sda

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Gwendal Grignou
Yours work. On Fri, Mar 29, 2013 at 9:10 AM, Krzysztof Mazur wrote: > On Fri, Mar 29, 2013 at 08:26:41AM -0700, Gwendal Grignou wrote: >> commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key >> used for returning task registers, but HDIO_DRIVE_CMD ioctl was >> not changed accordi

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Krzysztof Mazur
On Fri, Mar 29, 2013 at 08:26:41AM -0700, Gwendal Grignou wrote: > commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key > used for returning task registers, but HDIO_DRIVE_CMD ioctl was > not changed accordingly. > > Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD return

[PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Gwendal Grignou
commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO. Signed-off-by: Gwendal Grignou --- drivers/ata/libat

[PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-28 Thread Gwendal Grignou
commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO. Signed-off-by: Gwendal Grignou --- drivers/ata/libat