Re: [PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-28 Thread Andrey Utkin
On Tue, Feb 28, 2017 at 09:20:53AM +0100, Arnd Bergmann wrote: > On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin > wrote: > > Retcode checking takes place everywhere, but currently it overwrites > > supplied structs with potentially-uninitialized values. To make it

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-28 Thread Andrey Utkin
On Tue, Feb 28, 2017 at 09:20:53AM +0100, Arnd Bergmann wrote: > On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin > wrote: > > Retcode checking takes place everywhere, but currently it overwrites > > supplied structs with potentially-uninitialized values. To make it > > cleaner, it should be (e.g.

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-28 Thread Arnd Bergmann
On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin wrote: > Hi Arnd, > > Thanks for sending this patch. > > On Mon, Feb 27, 2017 at 09:32:34PM +0100, Arnd Bergmann wrote: >> tw5864_frameinterval_get() only initializes its output when it successfully >> identifies the

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-28 Thread Arnd Bergmann
On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin wrote: > Hi Arnd, > > Thanks for sending this patch. > > On Mon, Feb 27, 2017 at 09:32:34PM +0100, Arnd Bergmann wrote: >> tw5864_frameinterval_get() only initializes its output when it successfully >> identifies the video standard in tw5864_input. We

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-27 Thread Andrey Utkin
Hi Arnd, Thanks for sending this patch. On Mon, Feb 27, 2017 at 09:32:34PM +0100, Arnd Bergmann wrote: > tw5864_frameinterval_get() only initializes its output when it successfully > identifies the video standard in tw5864_input. We get a warning here because > gcc can't always track the state

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-27 Thread Andrey Utkin
Hi Arnd, Thanks for sending this patch. On Mon, Feb 27, 2017 at 09:32:34PM +0100, Arnd Bergmann wrote: > tw5864_frameinterval_get() only initializes its output when it successfully > identifies the video standard in tw5864_input. We get a warning here because > gcc can't always track the state

[PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-27 Thread Arnd Bergmann
tw5864_frameinterval_get() only initializes its output when it successfully identifies the video standard in tw5864_input. We get a warning here because gcc can't always track the state if initialized warnings across a WARN() macro, and thinks it might get used incorrectly in tw5864_s_parm:

[PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-27 Thread Arnd Bergmann
tw5864_frameinterval_get() only initializes its output when it successfully identifies the video standard in tw5864_input. We get a warning here because gcc can't always track the state if initialized warnings across a WARN() macro, and thinks it might get used incorrectly in tw5864_s_parm: