Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-04-08 Thread Laurent Pinchart
Hi Olivier, On Wednesday 02 April 2014 00:31:59 Olivier Langlois wrote: > On Tue, 2014-04-01 at 15:49 +0200, Laurent Pinchart wrote: > > On Sunday 30 March 2014 00:23:01 Olivier Langlois wrote: > > > > > Yes. ffmpeg uses wall clock time to create timestamps for audio > > > > > packets from ALSA de

Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-04-01 Thread Olivier Langlois
Hi Laurent, On Tue, 2014-04-01 at 15:49 +0200, Laurent Pinchart wrote: > Hi Olivier, > > On Sunday 30 March 2014 00:23:01 Olivier Langlois wrote: > > Hi Laurent, > > > > > > Yes. ffmpeg uses wall clock time to create timestamps for audio packets > > > > from ALSA device. > > > > > > OK. I suppo

Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-04-01 Thread Laurent Pinchart
Hi Olivier, On Sunday 30 March 2014 00:23:01 Olivier Langlois wrote: > Hi Laurent, > > > > Yes. ffmpeg uses wall clock time to create timestamps for audio packets > > > from ALSA device. > > > > OK. I suppose I shouldn't drop support for the realtime clock like I > > wanted to then :-) > > > >

Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-03-29 Thread Olivier Langlois
Hi Laurent, > > Yes. ffmpeg uses wall clock time to create timestamps for audio packets from > > ALSA device. > > OK. I suppose I shouldn't drop support for the realtime clock like I wanted > to > then :-) > > > There is a bug in ffmpeg describing problems to synchronize audio and > > the vid

Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-03-28 Thread Olivier Langlois
> > > > > > Before applying this, I'm curious, do you have a use case for realtime > > > time stamps ? > > > > Yes. ffmpeg uses wall clock time to create timestamps for audio packets from > > ALSA device. > > OK. I suppose I shouldn't drop support for the realtime clock like I wanted > to > t

Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-03-28 Thread Laurent Pinchart
Hi Olivier, On Friday 28 March 2014 17:27:08 Olivier Langlois wrote: > On Fri, 2014-03-28 at 17:20 +0100, Laurent Pinchart wrote: > > On Friday 28 March 2014 01:42:38 Olivier Langlois wrote: > > > timestamps in v4l2 buffers returned to userspace are updated in > > > uvc_video_clock_update() which

Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-03-28 Thread Olivier Langlois
Hi Laurent, On Fri, 2014-03-28 at 17:20 +0100, Laurent Pinchart wrote: > Hi Olivier, > > Thank you for the patch. > > On Friday 28 March 2014 01:42:38 Olivier Langlois wrote: > > timestamps in v4l2 buffers returned to userspace are updated in > > uvc_video_clock_update() which uses timestamps f

Re: [PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-03-28 Thread Laurent Pinchart
Hi Olivier, Thank you for the patch. On Friday 28 March 2014 01:42:38 Olivier Langlois wrote: > timestamps in v4l2 buffers returned to userspace are updated in > uvc_video_clock_update() which uses timestamps fetched from > uvc_video_clock_decode() by calling unconditionally ktime_get_ts(). > >

[PATCH] [media] uvcvideo: Fix clock param realtime setting

2014-03-27 Thread Olivier Langlois
timestamps in v4l2 buffers returned to userspace are updated in uvc_video_clock_update() which uses timestamps fetched from uvc_video_clock_decode() by calling unconditionally ktime_get_ts(). Hence setting the module clock param to realtime have no effect before this patch. This has been tested w