Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-20 Thread David Miller
From: Gaurav Singh Date: Thu, 18 Jun 2020 16:36:31 -0400 > parent cannot be NULL here since its in the else part > of the if (parent == NULL) condition. Remove the extra > check on parent pointer. > > Signed-off-by: Gaurav Singh Applied to net-next, thanks.

[PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-18 Thread Gaurav Singh
parent cannot be NULL here since its in the else part of the if (parent == NULL) condition. Remove the extra check on parent pointer. Signed-off-by: Gaurav Singh --- net/sched/sch_api.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sched/sch_api.c

Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-18 Thread David Miller
From: Gaurav Singh Date: Thu, 18 Jun 2020 00:00:56 -0400 > parent cannot be NULL here since its in the else part > of the if (parent == NULL) condition. Remove the extra > check on parent pointer. > > Signed-off-by: Gaurav Singh > --- > net/sched/sch_api.c | 2 +- > 1 file changed, 1

Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-18 Thread kernel test robot
Hi Gaurav, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.8-rc1 next-20200617] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in

[PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-17 Thread Gaurav Singh
parent cannot be NULL here since its in the else part of the if (parent == NULL) condition. Remove the extra check on parent pointer. Signed-off-by: Gaurav Singh --- net/sched/sch_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c

Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-17 Thread Eric Dumazet
On 6/17/20 6:23 PM, Gaurav Singh wrote: > Signed-off-by: Gaurav Singh Two Signed-off-by ? > > Fix build errors Your patch does not fix a build error. > > Signed-off-by: Gaurav Singh > --- > net/sched/sch_api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-17 Thread Jakub Kicinski
On Wed, 17 Jun 2020 20:55:26 -0400 Gaurav Singh wrote: > parent cannot be NULL here since its in the else part > of the if (parent == NULL) condition. Remove the extra > check on parent pointer. > > Signed-off-by: Gaurav Singh Change seems legit, but it obviously doesn't build... >

[PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-17 Thread Gaurav Singh
Signed-off-by: Gaurav Singh Fix build errors Signed-off-by: Gaurav Singh --- net/sched/sch_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index 9a3449b56bd6..be93ebcdb18d 100644 --- a/net/sched/sch_api.c +++

[PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-17 Thread Gaurav Singh
parent cannot be NULL here since its in the else part of the if (parent == NULL) condition. Remove the extra check on parent pointer. Signed-off-by: Gaurav Singh --- net/sched/sch_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c