Re: [PATCH] [net/sched] Fix null pointer deref skb in tc_ctl_action

2020-06-19 Thread kernel test robot
Hi Gaurav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in

Re: [PATCH] [net/sched] Fix null pointer deref skb in tc_ctl_action

2020-06-18 Thread David Miller
From: Gaurav Singh Date: Wed, 17 Jun 2020 21:43:28 -0400 > Add null check for skb > > Signed-off-by: Gaurav Singh > --- > net/sched/act_api.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/sched/act_api.c b/net/sched/act_api.c > index

Re: [PATCH] [net/sched] Fix null pointer deref skb in tc_ctl_action

2020-06-17 Thread Eric Dumazet
On 6/17/20 6:43 PM, Gaurav Singh wrote: > Add null check for skb > Bad choice really. You have to really understand code intent before trying to fix it. > Signed-off-by: Gaurav Singh > --- > net/sched/act_api.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

[PATCH] [net/sched] Fix null pointer deref skb in tc_ctl_action

2020-06-17 Thread Gaurav Singh
Add null check for skb Signed-off-by: Gaurav Singh --- net/sched/act_api.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/sched/act_api.c b/net/sched/act_api.c index 8ac7eb0a8309..fd584821d75a 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -1473,9