Re: [PATCH] [net] nvmem: disallow modular CONFIG_NVMEM

2018-04-04 Thread David Miller
From: Arnd Bergmann Date: Wed, 4 Apr 2018 12:38:40 +0200 > The new of_get_nvmem_mac_address() helper function causes a link error > with CONFIG_NVMEM=m: > > drivers/of/of_net.o: In function `of_get_nvmem_mac_address': > of_net.c:(.text+0x168): undefined reference to `of_nvmem_cell_get' > of_net

Re: [PATCH] [net] nvmem: disallow modular CONFIG_NVMEM

2018-04-04 Thread Arnd Bergmann
On Wed, Apr 4, 2018 at 3:32 PM, Mike Looijmans wrote: > > Which may still be very confusing, since it means that CONFIG_MACB=y with > CONFIG_NVMEM=m will fail, but setting both to "y" or both to "m" will work. > So that would introduce more build failures again, right? Right, it would require ha

Re: [PATCH] [net] nvmem: disallow modular CONFIG_NVMEM

2018-04-04 Thread Mike Looijmans
For making things build again: Acked-by: Mike Looijmans I'd be interested in use-cases for having nvmem as a module, I cannot think of any. I am working on splitting of_get_nvmem_mac_address(), by moving most of its burden to the nvmem interface. Intend to create this "just give me my bytes

[PATCH] [net] nvmem: disallow modular CONFIG_NVMEM

2018-04-04 Thread Arnd Bergmann
The new of_get_nvmem_mac_address() helper function causes a link error with CONFIG_NVMEM=m: drivers/of/of_net.o: In function `of_get_nvmem_mac_address': of_net.c:(.text+0x168): undefined reference to `of_nvmem_cell_get' of_net.c:(.text+0x19c): undefined reference to `nvmem_cell_read' of_net.c:(.te