Re: [PATCH] [net-next] cxgb4: reduce kernel stack usage in cudbg_collect_mem_region()

2019-07-13 Thread Arnd Bergmann
On Sat, Jul 13, 2019 at 2:14 AM Joe Perches wrote: > > On Fri, 2019-07-12 at 15:36 -0700, David Miller wrote: > > From: Arnd Bergmann > > Date: Fri, 12 Jul 2019 11:06:33 +0200 > > > > > The cudbg_collect_mem_region() and cudbg_read_fw_mem() both use several > > > hundred kilobytes of kernel stack

Re: [PATCH] [net-next] cxgb4: reduce kernel stack usage in cudbg_collect_mem_region()

2019-07-12 Thread Joe Perches
On Fri, 2019-07-12 at 15:36 -0700, David Miller wrote: > From: Arnd Bergmann > Date: Fri, 12 Jul 2019 11:06:33 +0200 > > > The cudbg_collect_mem_region() and cudbg_read_fw_mem() both use several > > hundred kilobytes of kernel stack space. Several hundred 'kilo' bytes? I hope not.

Re: [PATCH] [net-next] cxgb4: reduce kernel stack usage in cudbg_collect_mem_region()

2019-07-12 Thread David Miller
From: Arnd Bergmann Date: Fri, 12 Jul 2019 11:06:33 +0200 > The cudbg_collect_mem_region() and cudbg_read_fw_mem() both use several > hundred kilobytes of kernel stack space. One gets inlined into the other, > which causes the stack usage to be combined beyond the warning limit > when building wi

[PATCH] [net-next] cxgb4: reduce kernel stack usage in cudbg_collect_mem_region()

2019-07-12 Thread Arnd Bergmann
The cudbg_collect_mem_region() and cudbg_read_fw_mem() both use several hundred kilobytes of kernel stack space. One gets inlined into the other, which causes the stack usage to be combined beyond the warning limit when building with clang: drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:1057:12: e