Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 01:10:07AM +0100, Ondrej Zary wrote: > > > +typedef enum { EL3_ISA, EL3_PNP, EL3_MCA, EL3_EISA } el3_cardtype; > > > + > > > > No typedef please (see checkpatch) > > Is there any standard way to solve this without a typedef? I added > el3_dev_fill() function which fills

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Ondrej Zary
On Saturday 09 February 2008 22:48:05 Stephen Hemminger wrote: > On Sat, 9 Feb 2008 22:33:07 +0100 > > Ondrej Zary <[EMAIL PROTECTED]> wrote: > > Hello, > > this patch converts 3c509 driver to isa_driver and pnp_driver. The result > > is that autoloading using udev and hibernation works with ISA

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Stephen Hemminger
On Sat, 9 Feb 2008 22:33:07 +0100 Ondrej Zary <[EMAIL PROTECTED]> wrote: > Hello, > this patch converts 3c509 driver to isa_driver and pnp_driver. The result is > that autoloading using udev and hibernation works with ISA PnP cards. It also > adds hibernation support for non-PnP ISA cards. > >

[PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Ondrej Zary
Hello, this patch converts 3c509 driver to isa_driver and pnp_driver. The result is that autoloading using udev and hibernation works with ISA PnP cards. It also adds hibernation support for non-PnP ISA cards. xcvr module parameter was removed as its value was not used. Tested using 3 ISA

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Stephen Hemminger
On Sat, 9 Feb 2008 22:33:07 +0100 Ondrej Zary [EMAIL PROTECTED] wrote: Hello, this patch converts 3c509 driver to isa_driver and pnp_driver. The result is that autoloading using udev and hibernation works with ISA PnP cards. It also adds hibernation support for non-PnP ISA cards. xcvr

[PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Ondrej Zary
Hello, this patch converts 3c509 driver to isa_driver and pnp_driver. The result is that autoloading using udev and hibernation works with ISA PnP cards. It also adds hibernation support for non-PnP ISA cards. xcvr module parameter was removed as its value was not used. Tested using 3 ISA

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Ondrej Zary
On Saturday 09 February 2008 22:48:05 Stephen Hemminger wrote: On Sat, 9 Feb 2008 22:33:07 +0100 Ondrej Zary [EMAIL PROTECTED] wrote: Hello, this patch converts 3c509 driver to isa_driver and pnp_driver. The result is that autoloading using udev and hibernation works with ISA PnP cards.

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 01:10:07AM +0100, Ondrej Zary wrote: +typedef enum { EL3_ISA, EL3_PNP, EL3_MCA, EL3_EISA } el3_cardtype; + No typedef please (see checkpatch) Is there any standard way to solve this without a typedef? I added el3_dev_fill() function which fills that card type