Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-11 Thread Andrew Morton
> On Mon, 12 Mar 2007 10:52:22 +0800 Joe Jin <[EMAIL PROTECTED]> wrote: > > The 2.6.9 base is very old in mainline terms. Are you sure the bug hasn't > > been fixed in mainline by other means? > > I cannot confirm if it have fixed in latest kernel, the server is a > production system, it's hard t

Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-11 Thread Joe Jin
> The 2.6.9 base is very old in mainline terms. Are you sure the bug hasn't > been fixed in mainline by other means? I cannot confirm if it have fixed in latest kernel, the server is a production system, it's hard to debug it and try reproduce. - To unsubscribe from this list: send the line "uns

Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-11 Thread Joe Jin
> > This is a bug actually in the megaraid. Aha, I'll track it. > > And this is a direct command submission path: it already passed both > online check gates in this path *after* the device was offlined, so > adding a third won't fix this. Yeah, I have notice that, however, from the logs, th

Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-11 Thread James Bottomley
On Fri, 2007-03-09 at 09:40 +0800, Joe Jin wrote: > > What's the error you're trying to fix? scsi_dispatch_cmd() is only > > called from scsi_request_fn() which already has an equivalent of this > > check in it just prior to calling dispatch. > > Yeah, I have saw the cheking at scsi_request_fn(),

Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-11 Thread Andrew Morton
> On Fri, 9 Mar 2007 09:40:40 +0800 Joe Jin <[EMAIL PROTECTED]> wrote: > > What's the error you're trying to fix? scsi_dispatch_cmd() is only > > called from scsi_request_fn() which already has an equivalent of this > > check in it just prior to calling dispatch. > > Yeah, I have saw the cheking

Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-08 Thread Joe Jin
> What's the error you're trying to fix? scsi_dispatch_cmd() is only > called from scsi_request_fn() which already has an equivalent of this > check in it just prior to calling dispatch. Yeah, I have saw the cheking at scsi_request_fn(), recently we got a crash info as following at rhel4 2.6.9-42

Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-08 Thread James Bottomley
On Thu, 2007-03-08 at 17:22 +0800, Joe Jin wrote: > While a scsi device hw error occured, device's status maybe setting > to SDEV_OFFLINE, So at scsi_dispatch_cmd function, we should checking > if device have offline, if yes, do nothing and just return error to > user directly. What's the error y

[PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-08 Thread Joe Jin
While a scsi device hw error occured, device's status maybe setting to SDEV_OFFLINE, So at scsi_dispatch_cmd function, we should checking if device have offline, if yes, do nothing and just return error to user directly. Signed-off-by: Joe Jin <[EMAIL PROTECTED]> -- --- linux-2.6.21-rc2/drivers/