Re: [PATCH] [v2] ext4: Fix error handling code in add_new_gdb

2020-10-02 Thread Theodore Y. Ts'o
On Sat, Aug 29, 2020 at 10:54:02AM +0800, Dinghao Liu wrote: > When ext4_journal_get_write_access() fails, we should > terminate the execution flow and release n_group_desc, > iloc.bh, dind and gdb_bh. > > Signed-off-by: Dinghao Liu Thanks, applied. - Ted

Re: [PATCH] [v2] ext4: Fix error handling code in add_new_gdb

2020-08-29 Thread Andreas Dilger
On Aug 28, 2020, at 8:54 PM, Dinghao Liu wrote: > > When ext4_journal_get_write_access() fails, we should > terminate the execution flow and release n_group_desc, > iloc.bh, dind and gdb_bh. > > Signed-off-by: Dinghao Liu Looks good. I also reviewed the other error conditions in this function

[PATCH] [v2] ext4: Fix error handling code in add_new_gdb

2020-08-28 Thread Dinghao Liu
When ext4_journal_get_write_access() fails, we should terminate the execution flow and release n_group_desc, iloc.bh, dind and gdb_bh. Signed-off-by: Dinghao Liu --- Changelog: v2: - Remove changes to ext4_handle_dirty_super()'s error handling path. --- fs/ext4/resize.c | 4 +++- 1 file