Re: [PATCH v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error in ak8974_probe()

2020-06-27 Thread Jonathan Cameron
On Thu, 25 Jun 2020 14:34:44 +0200 Markus Elfring wrote: > https://lkml.org/lkml/2020/6/14/117 > https://lore.kernel.org/patchwork/comment/1452516/ > https://lore.kernel.org/linux-iio/20200614131116.143bcf92@archlinux/ > > > There was a lot of fuzz in this one due to other changes to the

Re: [PATCH v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error in ak8974_probe()

2020-06-25 Thread Markus Elfring
https://lkml.org/lkml/2020/6/14/117 https://lore.kernel.org/patchwork/comment/1452516/ https://lore.kernel.org/linux-iio/20200614131116.143bcf92@archlinux/ > There was a lot of fuzz in this one due to other changes to the driver. > I 'think' it went it cleanly though. Is it interesting anyhow

Re: [PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-06-14 Thread Jonathan Cameron
On Mon, 8 Jun 2020 14:12:18 +0200 Linus Walleij wrote: > Hi Jonathan, > > sorry for missing this :( > > On Sun, May 31, 2020 at 4:00 PM Jonathan Cameron wrote: > > On Tue, 26 May 2020 13:13:56 +0200 > > Linus Walleij wrote: > > > > > On Tue, May 26, 2020 at 12:47 PM Dinghao Liu > > >

Re: [PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-06-08 Thread Linus Walleij
Hi Jonathan, sorry for missing this :( On Sun, May 31, 2020 at 4:00 PM Jonathan Cameron wrote: > On Tue, 26 May 2020 13:13:56 +0200 > Linus Walleij wrote: > > > On Tue, May 26, 2020 at 12:47 PM Dinghao Liu wrote: > > > > > When devm_regmap_init_i2c() returns an error code, a pairing > > >

Re: [PATCH v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error in ak8974_probe()

2020-05-31 Thread Markus Elfring
> When devm_regmap_init_i2c() returns an error code, a pairing > runtime PM usage counter decrement is needed to keep the > counter balanced. How do you think about to replace the word “pairing” by “corresponding”? > For error paths after ak8974_set_power(), > ak8974_detect() and

Re: [PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-05-31 Thread Jonathan Cameron
On Tue, 26 May 2020 13:13:56 +0200 Linus Walleij wrote: > On Tue, May 26, 2020 at 12:47 PM Dinghao Liu wrote: > > > When devm_regmap_init_i2c() returns an error code, a pairing > > runtime PM usage counter decrement is needed to keep the > > counter balanced. For error paths after

Re: [PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-05-26 Thread Linus Walleij
On Tue, May 26, 2020 at 12:47 PM Dinghao Liu wrote: > When devm_regmap_init_i2c() returns an error code, a pairing > runtime PM usage counter decrement is needed to keep the > counter balanced. For error paths after ak8974_set_power(), > ak8974_detect() and ak8974_reset(), things are the same. >

[PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-05-26 Thread Dinghao Liu
When devm_regmap_init_i2c() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. For error paths after ak8974_set_power(), ak8974_detect() and ak8974_reset(), things are the same. However, When iio_triggered_buffer_setup() returns an error