Re: [PATCH] [v2] tools/objtool: Fix unnecessary jumps

2020-08-11 Thread Kamalesh Babulal
On 11/08/20 9:48 am, Youling Tang wrote: > There is no need to jump to the "out" tag when "ret < 0", just return > directly to "ret". > > Signed-off-by: Youling Tang the patch looks good to me, the commit message doesn't explain the reason for the change. It can be written like: "Previously

[PATCH] [v2] tools/objtool: Fix unnecessary jumps

2020-08-10 Thread Youling Tang
There is no need to jump to the "out" tag when "ret < 0", just return directly to "ret". Signed-off-by: Youling Tang --- tools/objtool/check.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index