Re: [PATCH] [v6] wireless: Initial driver submission for pureLiFi STA devices

2020-10-19 Thread Srinivasan Raju
> When you do, please start adding > changelog information below the > --- > line to your patches. > > It's quite a chore to figure out > what changed between revisions. Ok, will add version logs to future revisions. Thanks Srini

Re: [PATCH] [v6] wireless: Initial driver submission for pureLiFi STA devices

2020-10-19 Thread Joe Perches
On Mon, 2020-10-19 at 16:40 +, Srinivasan Raju wrote: > > Overall, there are many magic numbers without comments, this makes it hard > > to > > understand the code. Using defines with proper naming helps and for 802.11 > > stuff > > can use ieee80211_*/IEEE80211_* should be used. > > Thanks

Re: [PATCH] [v6] wireless: Initial driver submission for pureLiFi STA devices

2020-10-19 Thread Srinivasan Raju
> Overall, there are many magic numbers without comments, this makes it hard to > understand the code. Using defines with proper naming helps and for 802.11 > stuff > can use ieee80211_*/IEEE80211_* should be used. Thanks for your comments Krishna, will work on them. Regards, Srini

Re: [PATCH] [v6] wireless: Initial driver submission for pureLiFi STA devices

2020-10-19 Thread Krishna Chaitanya
On Mon, Oct 19, 2020 at 4:01 PM Srinivasan Raju wrote: > > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. > > This driver implementation has been based on the zd1211rw driver. > > Driver is based on 802.11 softMAC Architecture and uses > native 802.11 for

[PATCH] [v6] wireless: Initial driver submission for pureLiFi STA devices

2020-10-19 Thread Srinivasan Raju
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices. This driver implementation has been based on the zd1211rw driver. Driver is based on 802.11 softMAC Architecture and uses native 802.11 for configuration and management. The driver is compiled and tested in