Re: [PATCH] 2.6.23-rc6: Fix NUMA Memory Policy Reference Counting

2007-09-18 Thread Christoph Lameter
On Tue, 18 Sep 2007, Andi Kleen wrote: > > The patch does require concurrent increments and decrements in the main > > fault patch. The potential is to create another bouncing cacheline for > > concurrent faults. This looks like it would cause a performance issue. > > While may be true correctn

Re: [PATCH] 2.6.23-rc6: Fix NUMA Memory Policy Reference Counting

2007-09-17 Thread Andi Kleen
> Handling policy ref counts for hugepages is a bit trickier. > huge_zonelist() returns a zone list that might come from a > shared or vma 'BIND policy. In this case, we should hold the > reference until after the huge page allocation in > dequeue_hugepage(). The patch modifies huge_zonelist()

Re: [PATCH] 2.6.23-rc6: Fix NUMA Memory Policy Reference Counting

2007-09-17 Thread Andi Kleen
> The patch does require concurrent increments and decrements in the main > fault patch. The potential is to create another bouncing cacheline for > concurrent faults. This looks like it would cause a performance issue. While may be true correctness is always more important than performance. So

Re: [PATCH] 2.6.23-rc6: Fix NUMA Memory Policy Reference Counting

2007-09-17 Thread Christoph Lameter
On Mon, 17 Sep 2007, Lee Schermerhorn wrote: > Only for vma policy, right? show_numa_maps() isn't a performance path, > and shared policies are already reference counted--just not unref'd! Right. > I do have some ideas for enhancements to memtoy to test vma policies in > a multi-threaded task.

Re: [PATCH] 2.6.23-rc6: Fix NUMA Memory Policy Reference Counting

2007-09-17 Thread Lee Schermerhorn
On Mon, 2007-09-17 at 12:37 -0700, Christoph Lameter wrote: > On Mon, 17 Sep 2007, Lee Schermerhorn wrote: > > > Here is the 23-rc6 verison of the patch. Andi considers it a high > > priority bug fix for .23. I'm a bit uncomfortable with this, this late > > in the 23 cycle. I've not heard of pr

Re: [PATCH] 2.6.23-rc6: Fix NUMA Memory Policy Reference Counting

2007-09-17 Thread Christoph Lameter
On Mon, 17 Sep 2007, Lee Schermerhorn wrote: > Here is the 23-rc6 verison of the patch. Andi considers it a high > priority bug fix for .23. I'm a bit uncomfortable with this, this late > in the 23 cycle. I've not heard of problems w/o this patch, but then, > maybe no one notices if they leak a

[PATCH] 2.6.23-rc6: Fix NUMA Memory Policy Reference Counting

2007-09-17 Thread Lee Schermerhorn
Here is the 23-rc6 verison of the patch. Andi considers it a high priority bug fix for .23. I'm a bit uncomfortable with this, this late in the 23 cycle. I've not heard of problems w/o this patch, but then, maybe no one notices if they leak a memory policy struct now and then, or occasionally al