> >
> > Again, if anything in this flow doesn't happen HW mic mute is still
> activated,
> > just will take longer (for duration of timeout) and have popping noise.
>
> Thank you, can we put this in a comment in the driver please ?
Yes, I agree. I suggested to Perry that his next submission of
Hi,
On 11/12/20 4:31 PM, Limonciello, Mario wrote:
>>> Pressing the mute key activates a time delayed circuit to physically cut
>>> off the mute. The LED is in the same circuit, so it reflects the true
>>> state of the HW mute. The reason for the EC "ack" is so that software
>>> can first
> > Pressing the mute key activates a time delayed circuit to physically cut
> > off the mute. The LED is in the same circuit, so it reflects the true
> > state of the HW mute. The reason for the EC "ack" is so that software
> > can first invoke a SW mute before the HW circuit is cut off.
On 11.11.20 15:30, Limonciello, Mario wrote:
Hi,
> Pressing the mute key activates a time delayed circuit to physically cut
> off the mute. The LED is in the same circuit, so it reflects the true
> state of the HW mute. The reason for the EC "ack" is so that software
> can first invoke a SW
>
> On Wed, Nov 11, 2020 at 07:21:07AM +, Yuan, Perry wrote:
> > > > +status = acpi_evaluate_object(NULL, ACPI_PRIVACY_EC_ACK, NULL,
> > > NULL);
> > > > +if (ACPI_FAILURE(status)) {
> > > > +dev_err(led_cdev->dev, "Error setting privacy audio EC ack
> > > value:
> Subject: Re: [PATCH] platform/x86: dell-privacy: Add support for new privacy
> driver
>
>
> [EXTERNAL EMAIL]
>
> Hi,
>
> On 11/3/20 1:55 PM, Perry Yuan wrote:
> > From: perry_yuan
> >
> > add support for dell privacy driver for the dell units equipped
On Wed, Nov 11, 2020 at 07:21:07AM +, Yuan, Perry wrote:
> > > +status = acpi_evaluate_object(NULL, ACPI_PRIVACY_EC_ACK, NULL,
> > NULL);
> > > +if (ACPI_FAILURE(status)) {
> > > +dev_err(led_cdev->dev, "Error setting privacy audio EC ack
> > value: %d\n",status);
> > > +
> Subject: Re: [PATCH] platform/x86: dell-privacy: Add support for new privacy
> driver
>
>
> [EXTERNAL EMAIL]
>
> On Tue, Nov 03, 2020 at 04:55:42AM -0800, Perry Yuan wrote:
>
> > +#define PRIVACY_PlATFORM_NAME "dell-privacy-acpi"
> > +#define ACP
Hi,
On 11/3/20 1:55 PM, Perry Yuan wrote:
> From: perry_yuan
>
> add support for dell privacy driver for the dell units equipped
> hardware privacy design, which protect users privacy
> of audio and camera from hardware level. once the audio or camera
> privacy mode enabled, any
Hi Perry,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.10-rc2]
[cannot apply to next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use
On Tue, Nov 03, 2020 at 04:55:42AM -0800, Perry Yuan wrote:
> +#define PRIVACY_PlATFORM_NAME "dell-privacy-acpi"
> +#define ACPI_PRIVACY_DEVICE "\\_SB.PC00.LPCB.ECDV"
This looks like the EC rather than a privacy device? If so, you probably
want to collaborate with the EC driver to obtain the
Hi
(I really hope Hans and Mark won't get mad at me for writing some thoughts about
this patch.)
First of all, indentation should be tabs (= 8 spaces), not spaces. If I see it
correctly, the two are mixed here.
And please make the printed messages consistent (capitalization, etc.),
I believe
Hi Perry,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.10-rc2]
[cannot apply to next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use
Hi Perry,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.10-rc2]
[cannot apply to next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use
From: perry_yuan
add support for dell privacy driver for the dell units equipped
hardware privacy design, which protect users privacy
of audio and camera from hardware level. once the audio or camera
privacy mode enabled, any applications will not get any audio or
video stream.
when user
15 matches
Mail list logo
