Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-02 Thread Maciej W. Rozycki
On Fri, 2 Feb 2001, Mikael Pettersson wrote: > > I'm unsure about the K7_NMI_EVENT macro -- I think it should go into > > include/asm-i386/msr.h, but the comment should remain here. It should get > > reworded a bit in this case, I suppose, though. > > I'd prefer to keep it in nmi.c -- it

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-02 Thread Mikael Pettersson
Maciej W. Rozycki writes: > I've forgotten to cc you when sending Ingo my patch-2.4.0-ac12-upapic-19 > fixes a few days ago, my apologies. Since the two patches conflict with > each other, I've merged them together and provide the result below. > Please check if it is fine for you. Looks

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-02 Thread Maciej W. Rozycki
Mikael, I've forgotten to cc you when sending Ingo my patch-2.4.0-ac12-upapic-19 fixes a few days ago, my apologies. Since the two patches conflict with each other, I've merged them together and provide the result below. Please check if it is fine for you. I'm unsure about the K7_NMI_EVENT

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-02 Thread Petr Vandrovec
On 2 Feb 01 at 3:35, Mikael Pettersson wrote: > On Fri, 2 Feb 2001 01:37:28 +0100, Ingo Molnar wrote: > > On Thu, 1 Feb 2001, Mikael Pettersson wrote: > > > * NMI watchdog cleanups: mark setup_apic_nmi_watchdog() as __init, > > > fix the K7 init code to not leave any perfctr MSR uninitialised,

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-02 Thread Petr Vandrovec
On 2 Feb 01 at 3:35, Mikael Pettersson wrote: On Fri, 2 Feb 2001 01:37:28 +0100, Ingo Molnar wrote: On Thu, 1 Feb 2001, Mikael Pettersson wrote: * NMI watchdog cleanups: mark setup_apic_nmi_watchdog() as __init, fix the K7 init code to not leave any perfctr MSR uninitialised,

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-02 Thread Maciej W. Rozycki
Mikael, I've forgotten to cc you when sending Ingo my patch-2.4.0-ac12-upapic-19 fixes a few days ago, my apologies. Since the two patches conflict with each other, I've merged them together and provide the result below. Please check if it is fine for you. I'm unsure about the K7_NMI_EVENT

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-02 Thread Mikael Pettersson
Maciej W. Rozycki writes: I've forgotten to cc you when sending Ingo my patch-2.4.0-ac12-upapic-19 fixes a few days ago, my apologies. Since the two patches conflict with each other, I've merged them together and provide the result below. Please check if it is fine for you. Looks

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-02 Thread Maciej W. Rozycki
On Fri, 2 Feb 2001, Mikael Pettersson wrote: I'm unsure about the K7_NMI_EVENT macro -- I think it should go into include/asm-i386/msr.h, but the comment should remain here. It should get reworded a bit in this case, I suppose, though. I'd prefer to keep it in nmi.c -- it doesn't

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-01 Thread Mikael Pettersson
On Fri, 2 Feb 2001 01:37:28 +0100, Ingo Molnar wrote: > On Thu, 1 Feb 2001, Mikael Pettersson wrote: > > > This patch (against 2.4.1-ac1) contains the following fixes: > > * UP-APIC linkage fix: nr_ioapics must be moved from io_apic.c to > > mpparse.c to permit linking the kernel in pure

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-01 Thread Ingo Molnar
On Thu, 1 Feb 2001, Mikael Pettersson wrote: > This patch (against 2.4.1-ac1) contains the following fixes: > * UP-APIC linkage fix: nr_ioapics must be moved from io_apic.c to > mpparse.c to permit linking the kernel in pure UP-APIC configs. > * NMI watchdog cleanups: mark

[PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-01 Thread Mikael Pettersson
This patch (against 2.4.1-ac1) contains the following fixes: * UP-APIC linkage fix: nr_ioapics must be moved from io_apic.c to mpparse.c to permit linking the kernel in pure UP-APIC configs. * NMI watchdog cleanups: mark setup_apic_nmi_watchdog() as __init, fix the K7 init code to not leave

[PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-01 Thread Mikael Pettersson
This patch (against 2.4.1-ac1) contains the following fixes: * UP-APIC linkage fix: nr_ioapics must be moved from io_apic.c to mpparse.c to permit linking the kernel in pure UP-APIC configs. * NMI watchdog cleanups: mark setup_apic_nmi_watchdog() as __init, fix the K7 init code to not leave

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-01 Thread Ingo Molnar
On Thu, 1 Feb 2001, Mikael Pettersson wrote: This patch (against 2.4.1-ac1) contains the following fixes: * UP-APIC linkage fix: nr_ioapics must be moved from io_apic.c to mpparse.c to permit linking the kernel in pure UP-APIC configs. * NMI watchdog cleanups: mark

Re: [PATCH] 2.4.1-ac1 UP-APIC/NMI watchdog fixes

2001-02-01 Thread Mikael Pettersson
On Fri, 2 Feb 2001 01:37:28 +0100, Ingo Molnar wrote: On Thu, 1 Feb 2001, Mikael Pettersson wrote: This patch (against 2.4.1-ac1) contains the following fixes: * UP-APIC linkage fix: nr_ioapics must be moved from io_apic.c to mpparse.c to permit linking the kernel in pure UP-APIC