Re: [PATCH] 2.4.3-pre6 - hdlc/dscc4 missing bits

2001-03-21 Thread Krzysztof Halasa
Francois Romieu <[EMAIL PROTECTED]> writes: > What about the following (2.5 ?): > > - dev->type = ARPHRD_HDLC; > + dev->type = ARPHRD_CISCO; I'll replace ARPHRD_HDLC with ARPHRD_CISCO in the whole (AC) tree when 2.4.x kernel with '#define ARPHRD_CISCO' is out, leaving AR

Re: [PATCH] Re: [PATCH] Re: [PATCH] 2.4.3-pre6 - hdlc/dscc4 missing bits

2001-03-21 Thread Jeff Garzik
Francois Romieu wrote: > > Jeff Garzik <[EMAIL PROTECTED]> écrit : > > You should use this patch instead, from Alan's tree, for updating > > include/linux/if_arp.h... > > It adds confusion: do you imagine the poor soul who discovers hdlc in Linux > and sees ARPHRD_CISCO and ARPHRD_HDLC for the s

[PATCH] Re: [PATCH] Re: [PATCH] 2.4.3-pre6 - hdlc/dscc4 missing bits

2001-03-21 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> écrit : > You should use this patch instead, from Alan's tree, for updating > include/linux/if_arp.h... It adds confusion: do you imagine the poor soul who discovers hdlc in Linux and sees ARPHRD_CISCO and ARPHRD_HDLC for the same use after some hours of code-grepi

[PATCH] Re: [PATCH] 2.4.3-pre6 - hdlc/dscc4 missing bits

2001-03-21 Thread Jeff Garzik
You should use this patch instead, from Alan's tree, for updating include/linux/if_arp.h... -- Jeff Garzik | May you have warm words on a cold evening, Building 1024 | a full mooon on a dark night, MandrakeSoft | and a smooth road all the way to your door. Index: include/linux/if_

[PATCH] 2.4.3-pre6 - hdlc/dscc4 missing bits

2001-03-21 Thread Francois Romieu
- hdlc.c requires ARPHRD_CISCO (Cisco HDLC) to compile. This should* be ARPHRD_HDLC - the PCI_VENDOR/DEVICE_xxx for drivers/net/wan/dscc4.c haven't been included in the pci_ids db - drivers/net/wan/dscc4.c relies on ARPHRD_RAWHDLC (it's initialized as a transparent hdlc driver and I know no ARPH