Re: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread Andrey Borzenkov
On Saturday 27 October 2007, Anton Vorontsov wrote: > On Sat, Oct 27, 2007 at 08:54:30PM +0400, Andrey Borzenkov wrote: > > I am not exactly sure about this one ... what other power_supply class > > drivers do? Should I fix HAL instead (but then, I do not know whether HAL > > is the only applicatio

Re: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread Anton Vorontsov
On Sat, Oct 27, 2007 at 03:32:04PM -0400, David Woodhouse wrote: > On Sat, 2007-10-27 at 22:42 +0400, Anton Vorontsov wrote: > > Well, PROP_PRESENT wasn't my idea, currently it's used by pmu and > > olpc drivers becuase it's not trivial to register/unregister their > > batteries on physical inserti

Re: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread David Woodhouse
On Sat, 2007-10-27 at 22:42 +0400, Anton Vorontsov wrote: > Well, PROP_PRESENT wasn't my idea, currently it's used by pmu and > olpc drivers becuase it's not trivial to register/unregister their > batteries on physical insertion/removal. I have some plans to teach > at least pmu batteries to not us

Re: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread Anton Vorontsov
w1/slaves/w1_ds2760.c - is w1 slave, which registers/unregisters pdevs on the detection/removal. > Subject: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery > is absent Bad idea. Don't use present attribute, if possible. > From: Andrey Borzenkov <[EMAIL

Re: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > On Saturday 27 October 2007, Alexey Starikovskiy wrote: >> Andrey Borzenkov wrote: >>> I am not exactly sure about this one ... what other power_supply class >>> drivers do? Should I fix HAL instead (but then, I do not know whether HAL >>> is the only application that is u

Re: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread Andrey Borzenkov
On Saturday 27 October 2007, Alexey Starikovskiy wrote: > Andrey Borzenkov wrote: > > I am not exactly sure about this one ... what other power_supply class > > drivers do? Should I fix HAL instead (but then, I do not know whether HAL > > is the only application that is using this interface). > > H

Re: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > I am not exactly sure about this one ... what other power_supply class > drivers > do? Should I fix HAL instead (but then, I do not know whether HAL is the only > application that is using this interface). > > Hm, do you need separate set of properties for that? You c

[PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread Andrey Borzenkov
I am not exactly sure about this one ... what other power_supply class drivers do? Should I fix HAL instead (but then, I do not know whether HAL is the only application that is using this interface). Subject: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is a