Re: [PATCH] 3c574_cs: fix operator precedence between << and

2013-01-17 Thread David Miller
From: Nickolai Zeldovich Date: Thu, 17 Jan 2013 12:18:29 -0500 > The code to print the FIFO size in tc574_config computes it as: > > 8 << config & Ram_size > > which evaluates the '<<' first, but the actual intent is to evaluate the > '&' first. Add parentheses to enforce desired evaluation

[PATCH] 3c574_cs: fix operator precedence between << and

2013-01-17 Thread Nickolai Zeldovich
The code to print the FIFO size in tc574_config computes it as: 8 << config & Ram_size which evaluates the '<<' first, but the actual intent is to evaluate the '&' first. Add parentheses to enforce desired evaluation order. Signed-off-by: Nickolai Zeldovich ---

[PATCH] 3c574_cs: fix operator precedence between and

2013-01-17 Thread Nickolai Zeldovich
The code to print the FIFO size in tc574_config computes it as: 8 config Ram_size which evaluates the '' first, but the actual intent is to evaluate the '' first. Add parentheses to enforce desired evaluation order. Signed-off-by: Nickolai Zeldovich nicko...@csail.mit.edu ---

Re: [PATCH] 3c574_cs: fix operator precedence between and

2013-01-17 Thread David Miller
From: Nickolai Zeldovich nicko...@csail.mit.edu Date: Thu, 17 Jan 2013 12:18:29 -0500 The code to print the FIFO size in tc574_config computes it as: 8 config Ram_size which evaluates the '' first, but the actual intent is to evaluate the '' first. Add parentheses to enforce desired