Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-05 Thread Rafael J. Wysocki
On Tue, Dec 5, 2017 at 3:25 PM, Adrian Hunter wrote: > On 04/12/17 17:00, Rafael J. Wysocki wrote: >> On Monday, December 4, 2017 3:41:45 PM CET Adrian Hunter wrote: >>> On 04/12/17 16:33, Hans de Goede wrote: Hi, On 04-12-17 15:30, Adrian Hunter wrote: > On 04/12/17 15:48, Hans

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-05 Thread Adrian Hunter
On 04/12/17 17:00, Rafael J. Wysocki wrote: > On Monday, December 4, 2017 3:41:45 PM CET Adrian Hunter wrote: >> On 04/12/17 16:33, Hans de Goede wrote: >>> Hi, >>> >>> On 04-12-17 15:30, Adrian Hunter wrote: On 04/12/17 15:48, Hans de Goede wrote: > Hi, > > Wouldn't it be easier t

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Adrian Hunter
On 04/12/17 15:56, Carlo Caione wrote: > On Mon, Dec 4, 2017 at 12:32 PM, Adrian Hunter > wrote: >> Some Cherry Trail boards have a dependency between the SDHCI host >> controller used for SD cards and an external PMIC accessed via I2C. Add a >> device link between the SDHCI host controller (cons

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Rafael J. Wysocki
On Monday, December 4, 2017 3:41:45 PM CET Adrian Hunter wrote: > On 04/12/17 16:33, Hans de Goede wrote: > > Hi, > > > > On 04-12-17 15:30, Adrian Hunter wrote: > >> On 04/12/17 15:48, Hans de Goede wrote: > >>> Hi, > >>> > >>> Wouldn't it be easier to use the ACPI _DEP tracking for this, e.g. >

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Rafael J. Wysocki
On Monday, December 4, 2017 3:33:29 PM CET Hans de Goede wrote: > Hi, > > On 04-12-17 15:30, Adrian Hunter wrote: > > On 04/12/17 15:48, Hans de Goede wrote: > >> Hi, > >> > >> Wouldn't it be easier to use the ACPI _DEP tracking for this, e.g. > > > > It is using _DEP, see acpi_lpss_dep() > > >

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Adrian Hunter
On 04/12/17 16:33, Hans de Goede wrote: > Hi, > > On 04-12-17 15:30, Adrian Hunter wrote: >> On 04/12/17 15:48, Hans de Goede wrote: >>> Hi, >>> >>> Wouldn't it be easier to use the ACPI _DEP tracking for this, e.g. >> >> It is using _DEP, see acpi_lpss_dep() >> >>> add something like this to the

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Hans de Goede
Hi, On 04-12-17 15:30, Adrian Hunter wrote: On 04/12/17 15:48, Hans de Goede wrote: Hi, Wouldn't it be easier to use the ACPI _DEP tracking for this, e.g. It is using _DEP, see acpi_lpss_dep() add something like this to the the probe function: struct acpi_device = ACPI_COMPANION(devi

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Adrian Hunter
On 04/12/17 15:48, Hans de Goede wrote: > Hi, > > Wouldn't it be easier to use the ACPI _DEP tracking for this, e.g. It is using _DEP, see acpi_lpss_dep() > add something like this to the the probe function: > > struct acpi_device = ACPI_COMPANION(device); > > if (acpi_device->dep_unme

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Carlo Caione
On Mon, Dec 4, 2017 at 12:32 PM, Adrian Hunter wrote: > Some Cherry Trail boards have a dependency between the SDHCI host > controller used for SD cards and an external PMIC accessed via I2C. Add a > device link between the SDHCI host controller (consumer) and the I2C > adapter (supplier). > > Thi

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Hans de Goede
Hi, Wouldn't it be easier to use the ACPI _DEP tracking for this, e.g. add something like this to the the probe function: struct acpi_device = ACPI_COMPANION(device); if (acpi_device->dep_unmet) return -EPROBE_DEFER; No idea if this will work, but if it does wor

[PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Adrian Hunter
Some Cherry Trail boards have a dependency between the SDHCI host controller used for SD cards and an external PMIC accessed via I2C. Add a device link between the SDHCI host controller (consumer) and the I2C adapter (supplier). This patch depends on a fix to devices links, namely commit 0ff26c662