Re: [PATCH] ALSA: emu10k1: casting (void *) value returned by kcalloc is useless

2013-09-05 Thread Joe Perches
On Thu, 2013-09-05 at 18:10 +0800, Duan Jiong wrote: > 于 2013年09月05日 14:12, Joe Perches 写道: > > On Thu, 2013-09-05 at 13:57 +0800, Duan Jiong wrote: > >> From: Duan Jiong > >> > >> Casting (void *) value returned by kcalloc is useless > >> as mentioned in Documentation/CodingStyle, Chap 14. > > >

Re: [PATCH] ALSA: emu10k1: casting (void *) value returned by kcalloc is useless

2013-09-05 Thread Duan Jiong
于 2013年09月05日 14:12, Joe Perches 写道: > On Thu, 2013-09-05 at 13:57 +0800, Duan Jiong wrote: >> From: Duan Jiong >> >> Casting (void *) value returned by kcalloc is useless >> as mentioned in Documentation/CodingStyle, Chap 14. > > __user is an important marker that is lost here. > >> diff --git

Re: [PATCH] ALSA: emu10k1: casting (void *) value returned by kcalloc is useless

2013-09-04 Thread Joe Perches
On Thu, 2013-09-05 at 13:57 +0800, Duan Jiong wrote: > From: Duan Jiong > > Casting (void *) value returned by kcalloc is useless > as mentioned in Documentation/CodingStyle, Chap 14. __user is an important marker that is lost here. > diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/e

[PATCH] ALSA: emu10k1: casting (void *) value returned by kcalloc is useless

2013-09-04 Thread Duan Jiong
From: Duan Jiong Casting (void *) value returned by kcalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. Signed-off-by: Duan Jiong --- sound/pci/emu10k1/emufx.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sound/pci/emu10k1/emufx.c b/sound/pc