Re: [PATCH] ALSA: hda/realtek: Enable front panel headset LED on Lenovo ThinkStation P520

2020-09-21 Thread Takashi Iwai
On Mon, 14 Sep 2020 09:02:29 +0200, Kai-Heng Feng wrote: > > On Lenovo P520, the front panel headset LED isn't lit up right now. > > Realtek states that the LED needs to be enabled by ALC233's GPIO2, so > let's do it accordingly to light the LED up. > > Signed-off-by: Kai-Heng Feng Applied now

Re: [PATCH] ALSA: hda/realtek: Enable front panel headset LED on Lenovo ThinkStation P520

2020-09-14 Thread Hui Wang
OK,  then looks fine to me. Acked-by:Hui Wang On 2020/9/14 下午4:07, Kai-Heng Feng wrote: Hi Hui, On Sep 14, 2020, at 16:04, Hui Wang wrote: Thanks Kaiheng, and we just had one P520 in the Beijing office and I also worked on this issue happenly. Does the led change according to jack pluggin

Re: [PATCH] ALSA: hda/realtek: Enable front panel headset LED on Lenovo ThinkStation P520

2020-09-14 Thread Hui Wang
On 2020/9/14 下午4:07, Kai-Heng Feng wrote: Hi Hui, On Sep 14, 2020, at 16:04, Hui Wang wrote: Thanks Kaiheng, and we just had one P520 in the Beijing office and I also worked on this issue happenly. Does the led change according to jack plugging in or plugging out with your patch? No, the

Re: [PATCH] ALSA: hda/realtek: Enable front panel headset LED on Lenovo ThinkStation P520

2020-09-14 Thread Kai-Heng Feng
Hi Hui, > On Sep 14, 2020, at 16:04, Hui Wang wrote: > > Thanks Kaiheng, and we just had one P520 in the Beijing office and I also > worked on this issue happenly. Does the led change according to jack plugging > in or plugging out with your patch? No, the LED won't reflect the jack plugging

Re: [PATCH] ALSA: hda/realtek: Enable front panel headset LED on Lenovo ThinkStation P520

2020-09-14 Thread Hui Wang
Thanks Kaiheng, and we just had one P520 in the Beijing office and I also worked on this issue happenly. Does the led change according to jack plugging in or plugging out with your patch? I also prepared a patchset but my patchset has more code than yours, please take a look. :-) Thanks. Hui.

[PATCH] ALSA: hda/realtek: Enable front panel headset LED on Lenovo ThinkStation P520

2020-09-14 Thread Kai-Heng Feng
On Lenovo P520, the front panel headset LED isn't lit up right now. Realtek states that the LED needs to be enabled by ALC233's GPIO2, so let's do it accordingly to light the LED up. Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c | 7 +++ 1 file changed, 7 insertions(+) dif