Re: [PATCH] ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()

2019-07-25 Thread Jia-Ju Bai
On 2019/7/25 23:52, Takashi Iwai wrote: On Thu, 25 Jul 2019 10:27:33 +0200, Jia-Ju Bai wrote: In build_adc_controls(), there is an if statement on line 773 to check whether ak->adc_info is NULL: if (! ak->adc_info || ! ak->adc_info[mixer_ch].switch_name) When

Re: [PATCH] ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 10:27:33 +0200, Jia-Ju Bai wrote: > > In build_adc_controls(), there is an if statement on line 773 to check > whether ak->adc_info is NULL: > if (! ak->adc_info || > ! ak->adc_info[mixer_ch].switch_name) > > When ak->adc_info is NULL, it is used on line

[PATCH] ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()

2019-07-25 Thread Jia-Ju Bai
In build_adc_controls(), there is an if statement on line 773 to check whether ak->adc_info is NULL: if (! ak->adc_info || ! ak->adc_info[mixer_ch].switch_name) When ak->adc_info is NULL, it is used on line 792: knew.name = ak->adc_info[mixer_ch].selector_name; Thus,