Re: [PATCH] ALSA: lx6464es: lx_core: Remove some unused functions

2015-01-11 Thread Takashi Iwai
At Sun, 11 Jan 2015 12:18:06 -0800, Josh Triplett wrote: > > On Sun, Jan 11, 2015 at 04:55:23PM +0100, Takashi Iwai wrote: > > At Sun, 11 Jan 2015 16:43:02 +0100, > > Rickard Strandqvist wrote: > > > > > > Removes some functions that are not used anywhere: > > > lx_buffer_cancel()

Re: [PATCH] ALSA: lx6464es: lx_core: Remove some unused functions

2015-01-11 Thread Josh Triplett
On Sun, Jan 11, 2015 at 04:55:23PM +0100, Takashi Iwai wrote: > At Sun, 11 Jan 2015 16:43:02 +0100, > Rickard Strandqvist wrote: > > > > Removes some functions that are not used anywhere: > > lx_buffer_cancel() lx_buffer_free() lx_stream_sample_position() > > lx_stream_state()

Re: [PATCH] ALSA: lx6464es: lx_core: Remove some unused functions

2015-01-11 Thread Takashi Iwai
At Sun, 11 Jan 2015 16:43:02 +0100, Rickard Strandqvist wrote: > > Removes some functions that are not used anywhere: > lx_buffer_cancel() lx_buffer_free() lx_stream_sample_position() > lx_stream_state() lx_pipe_sample_count() We really shouldn't delete the code but keep somehow disabled for

[PATCH] ALSA: lx6464es: lx_core: Remove some unused functions

2015-01-11 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: lx_buffer_cancel() lx_buffer_free() lx_stream_sample_position() lx_stream_state() lx_pipe_sample_count() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist ---

[PATCH] ALSA: lx6464es: lx_core: Remove some unused functions

2015-01-11 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: lx_buffer_cancel() lx_buffer_free() lx_stream_sample_position() lx_stream_state() lx_pipe_sample_count() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [PATCH] ALSA: lx6464es: lx_core: Remove some unused functions

2015-01-11 Thread Takashi Iwai
At Sun, 11 Jan 2015 16:43:02 +0100, Rickard Strandqvist wrote: Removes some functions that are not used anywhere: lx_buffer_cancel() lx_buffer_free() lx_stream_sample_position() lx_stream_state() lx_pipe_sample_count() We really shouldn't delete the code but keep somehow disabled for such a

Re: [PATCH] ALSA: lx6464es: lx_core: Remove some unused functions

2015-01-11 Thread Josh Triplett
On Sun, Jan 11, 2015 at 04:55:23PM +0100, Takashi Iwai wrote: At Sun, 11 Jan 2015 16:43:02 +0100, Rickard Strandqvist wrote: Removes some functions that are not used anywhere: lx_buffer_cancel() lx_buffer_free() lx_stream_sample_position() lx_stream_state() lx_pipe_sample_count() We

Re: [PATCH] ALSA: lx6464es: lx_core: Remove some unused functions

2015-01-11 Thread Takashi Iwai
At Sun, 11 Jan 2015 12:18:06 -0800, Josh Triplett wrote: On Sun, Jan 11, 2015 at 04:55:23PM +0100, Takashi Iwai wrote: At Sun, 11 Jan 2015 16:43:02 +0100, Rickard Strandqvist wrote: Removes some functions that are not used anywhere: lx_buffer_cancel() lx_buffer_free()