Re: [PATCH] ALSA: mips: avoid potential uninitialized variable use

2017-01-16 Thread Arnd Bergmann
On Mon, Jan 16, 2017 at 1:28 PM, Takashi Iwai wrote: > On Mon, 16 Jan 2017 12:04:56 +0100, > Arnd Bergmann wrote: >> It's easy enough to avoid by adding a 'default' clause to the switch >> statements here. I assume that in practice no other case can happen, >> but adding a default puts us on the s

Re: [PATCH] ALSA: mips: avoid potential uninitialized variable use

2017-01-16 Thread Takashi Iwai
On Mon, 16 Jan 2017 12:04:56 +0100, Arnd Bergmann wrote: > > MIPS allmodconfig results in this warning: > > sound/mips/hal2.c: In function 'hal2_gain_get': > sound/mips/hal2.c:224:35: error: 'r' may be used uninitialized in this > function [-Werror=maybe-uninitialized] > sound/mips/hal2.c:223:35

[PATCH] ALSA: mips: avoid potential uninitialized variable use

2017-01-16 Thread Arnd Bergmann
MIPS allmodconfig results in this warning: sound/mips/hal2.c: In function 'hal2_gain_get': sound/mips/hal2.c:224:35: error: 'r' may be used uninitialized in this function [-Werror=maybe-uninitialized] sound/mips/hal2.c:223:35: error: 'l' may be used uninitialized in this function [-Werror=maybe-