Re: [PATCH] ALSA: usb-audio: Fix missing return assignment

2021-03-25 Thread Dan Carpenter
On Thu, Mar 25, 2021 at 01:24:23AM +0500, Muhammad Usama Anjum wrote: > On Wed, 2021-03-24 at 21:50 +0300, Dan Carpenter wrote: > > > - usb_driver_claim_interface(driver, iface, (void *)-1L); > > > + err = usb_driver_claim_interface(driver, iface, (void > > > *)-1L)

Re: [PATCH] ALSA: usb-audio: Fix missing return assignment

2021-03-24 Thread Muhammad Usama Anjum
On Wed, 2021-03-24 at 21:50 +0300, Dan Carpenter wrote: > On Wed, Mar 24, 2021 at 10:26:04PM +0500, Muhammad Usama Anjum wrote: > > Return value of usb_driver_claim_interface should not be ignored. > > Instead it should be stored in err variable and returned from > > this function. > > > > Signed-

Re: [PATCH] ALSA: usb-audio: Fix missing return assignment

2021-03-24 Thread Dan Carpenter
On Wed, Mar 24, 2021 at 10:26:04PM +0500, Muhammad Usama Anjum wrote: > Return value of usb_driver_claim_interface should not be ignored. > Instead it should be stored in err variable and returned from > this function. > > Signed-off-by: Muhammad Usama Anjum > --- > sound/usb/quirks.c | 4 ++-- >

[PATCH] ALSA: usb-audio: Fix missing return assignment

2021-03-24 Thread Muhammad Usama Anjum
Return value of usb_driver_claim_interface should not be ignored. Instead it should be stored in err variable and returned from this function. Signed-off-by: Muhammad Usama Anjum --- sound/usb/quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/usb/quirks.c b/s