Re: [PATCH] ARC: Change ld.as instruction to regular ld.

2016-08-25 Thread Vineet Gupta
On 08/25/2016 05:05 AM, Alexey Brodkin wrote: > Hi Liav, > > On Wed, 2016-08-17 at 09:23 +0300, Liav Rehana wrote: >> From: Liav Rehana >> >> User mode callee regs are explicitly collected before signal delivery >> or breakpoint trap. r25 is special for kernel as it serves as task >> pointer, so u

Re: [PATCH] ARC: Change ld.as instruction to regular ld.

2016-08-25 Thread Alexey Brodkin
Hi Liav, On Wed, 2016-08-17 at 09:23 +0300, Liav Rehana wrote: > From: Liav Rehana > > User mode callee regs are explicitly collected before signal delivery > or breakpoint trap. r25 is special for kernel as it serves as task > pointer, so user mode value is clobbered very early. It is saved in

Re: [PATCH] ARC: Change ld.as instruction to regular ld.

2016-08-17 Thread Vineet Gupta
On 08/16/2016 11:24 PM, Liav Rehana wrote: > From: Liav Rehana > > User mode callee regs are explicitly collected before signal delivery > or breakpoint trap. r25 is special for kernel as it serves as task > pointer, so user mode value is clobbered very early. It is saved in > pt_regs where genera

[PATCH] ARC: Change ld.as instruction to regular ld.

2016-08-17 Thread Liav Rehana
From: Liav Rehana User mode callee regs are explicitly collected before signal delivery or breakpoint trap. r25 is special for kernel as it serves as task pointer, so user mode value is clobbered very early. It is saved in pt_regs where generally only scratch (caller saved) res are saved. The cod

[PATCH] ARC: Change ld.as instruction to regular ld.

2016-08-16 Thread Liav Rehana
From: Liav Rehana The instruction ld.as takes as operands a base address and an offset, and doesn't access the sum of these two, but the sum of the base address and a shifted version of the offset. This isn't what we want in that case, since it causes a bug during the push and pop of r25, since h

Re: [PATCH] ARC: Change ld.as instruction to regular ld.

2016-08-16 Thread Vineet Gupta
On 08/16/2016 06:15 AM, Alexey Brodkin wrote: > Hi Liav, > > On Tue, 2016-08-16 at 10:55 +0300, Liav Rehana wrote: >> From: Liav Rehana >> >> The instruction ld.as takes as operands a base address and an offset, >> and doesn't access the sum of these two, but the sum of the base >> address and a

Re: [PATCH] ARC: Change ld.as instruction to regular ld.

2016-08-16 Thread Alexey Brodkin
Hi Liav, On Tue, 2016-08-16 at 10:55 +0300, Liav Rehana wrote: > From: Liav Rehana > > The instruction ld.as takes as operands a base address and an offset, > and doesn't access the sum of these two, but the sum of the base > address and a shifted version of the offset. > This isn't what we want