Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-16 Thread Pavel Machek
On Wed 2014-02-05 13:33:02, Sebastian Reichel wrote: > Without enabling the workaround for ARM errata 430973 thumb > compiled userland crashes randomly on the Nokia N900. > > Signed-off-by: Sebastian Reichel Reviewed-by: Pavel Machek > +static void __init nokia_n900_legacy_init(void) > +{ > +

Re: Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-05 Thread Sebastian Reichel
Hi, On Wed, Feb 05, 2014 at 10:30:52PM +0200, Ivaylo Dimitrov wrote: > In theory having that workaround disabled might be a security > problem, but honestly, knowing its nature I don't think it is easily > exploitable, if at all. The final result when bitten by it is a > SIGILL, but in userspace,

Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-05 Thread Sebastian Reichel
On Wed, Feb 05, 2014 at 09:42:30PM +0100, Pali Rohár wrote: > 2014-02-05 Sebastian Reichel : > > Hi, > > > > On Wed, Feb 05, 2014 at 05:38:54PM +0100, Pali Rohár wrote: > >> > I assumed, that the workaround is not needed for this device type. > >> > >> That rx51 secure call must not be called on no

Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-05 Thread Pali Rohár
2014-02-05 Sebastian Reichel : > Hi, > > On Wed, Feb 05, 2014 at 05:38:54PM +0100, Pali Rohár wrote: >> > I assumed, that the workaround is not needed for this device type. >> >> That rx51 secure call must not be called on non secure devices (e.g. >> qemu), because it cause kernel crash. So I thoug

Re: Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-05 Thread Ivaylo Dimitrov
Hi, On 5.02.2014 19:17, Sebastian Reichel wrote: Hi, On Wed, Feb 05, 2014 at 05:38:54PM +0100, Pali Rohár wrote: I assumed, that the workaround is not needed for this device type. That rx51 secure call must not be called on non secure devices (e.g. qemu), because it cause kernel crash. So I

Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-05 Thread Sebastian Reichel
Hi, On Wed, Feb 05, 2014 at 05:38:54PM +0100, Pali Rohár wrote: > > I assumed, that the workaround is not needed for this device type. > > That rx51 secure call must not be called on non secure devices (e.g. > qemu), because it cause kernel crash. So I thought that kernel should > write something

Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-05 Thread Pali Rohár
2014-02-05 Sebastian Reichel : > Hi Pali, > > On Wed, Feb 05, 2014 at 02:12:56PM +0100, Pali Rohár wrote: >> 1) Why are you using if (IS_ENABLED(CONFIG_ARM_ERRATA_430973)) instead >> #ifdef ? > > This is the preferred kernel style as far as I know. > Ok. >> 2) Why do you not write warning or inf

Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-05 Thread Sebastian Reichel
Hi Pali, On Wed, Feb 05, 2014 at 02:12:56PM +0100, Pali Rohár wrote: > 1) Why are you using if (IS_ENABLED(CONFIG_ARM_ERRATA_430973)) instead #ifdef > ? This is the preferred kernel style as far as I know. > 2) Why do you not write warning or info when omap type is not > OMAP2_DEVICE_TYPE_SEC (

Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-05 Thread Pali Rohár
2014-02-05 Sebastian Reichel : > Without enabling the workaround for ARM errata 430973 thumb > compiled userland crashes randomly on the Nokia N900. > > Signed-off-by: Sebastian Reichel > --- > Hi Tony, > > I think this patch should be added into some fix branch for 3.14-rcX. > > -- Sebastian > --

[PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

2014-02-05 Thread Sebastian Reichel
Without enabling the workaround for ARM errata 430973 thumb compiled userland crashes randomly on the Nokia N900. Signed-off-by: Sebastian Reichel --- Hi Tony, I think this patch should be added into some fix branch for 3.14-rcX. -- Sebastian --- arch/arm/mach-omap2/pdata-quirks.c | 19 +++